Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt.modules.disk shouldn't return numbers as strings #22383

Closed
arnisoph opened this issue Apr 6, 2015 · 2 comments
Closed

salt.modules.disk shouldn't return numbers as strings #22383

arnisoph opened this issue Apr 6, 2015 · 2 comments
Labels
Bug broken, incorrect, or confusing behavior Execution-Module help-wanted Community help is needed to resolve this P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-low 4th level, cosemtic problems, work around exists stale
Milestone

Comments

@arnisoph
Copy link
Contributor

arnisoph commented Apr 6, 2015

Temporary solution: https://github.com/bechtoldt/salt-modules/blob/master/_modules/diskarbe.py (a wrapping execution module)

I think it will be important not to break backwards compatibly immediately after fixing this issue. An optional argument could be added like num_as_str=True or similar.

@rallytime
Copy link
Contributor

Thanks @bechtoldt. I think you're right in that it would be nice to not have to convert to int. But we definitely don't want to break backwards compatibility. I think a keyword arg would be a good approach, and we can kind of put the functionality into a "deprecation path", warning the user that it's going to change in a feature release or two.

@rallytime rallytime added Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists help-wanted Community help is needed to resolve this P4 Priority 4 labels Apr 7, 2015
@rallytime rallytime added this to the Approved milestone Apr 7, 2015
@jfindlay jfindlay added the Platform Relates to OS, containers, platform-based utilities like FS, system based apps label May 26, 2015
@stale
Copy link

stale bot commented Nov 10, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Nov 10, 2017
@stale stale bot closed this as completed Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Execution-Module help-wanted Community help is needed to resolve this P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-low 4th level, cosemtic problems, work around exists stale
Projects
None yet
Development

No branches or pull requests

3 participants