Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deprecated neutron module #49430

Closed
1 task
rallytime opened this issue Aug 29, 2018 · 4 comments · Fixed by #63175
Closed
1 task

Handle deprecated neutron module #49430

rallytime opened this issue Aug 29, 2018 · 4 comments · Fixed by #63175
Assignees
Labels
Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Deprecation P1 Priority 1 Sulfur v3006.0 release code name and version

Comments

@rallytime
Copy link
Contributor

rallytime commented Aug 29, 2018

  • salt/utils/openstack/neutron.py

The neutron module has been replaced with neutronng.py. Anything relying on the neutron utils module must be addressed.

Don't forget to remove the autodoc files + references, as well as the stale doc files on the doc build server.

@rallytime rallytime added the ZRELEASED - Neon retired label label Aug 29, 2018
@rallytime rallytime added this to the Approved milestone Aug 29, 2018
@rallytime rallytime self-assigned this Aug 29, 2018
@rallytime rallytime assigned Ch3LL and unassigned rallytime Nov 15, 2018
@Ch3LL
Copy link
Contributor

Ch3LL commented Dec 16, 2019

going to bump the warn until version to aluminium due to this blocker: #55663

@Ch3LL Ch3LL added the ZRelease-Sodium retired label label Dec 16, 2019
@Ch3LL Ch3LL removed the ZRELEASED - Neon retired label label Dec 18, 2019
@sagetherage sagetherage changed the title Handle deprecated neutron module for Neon release Handle deprecated neutron module Jan 17, 2020
@sagetherage sagetherage added the Confirmed Salt engineer has confirmed bug/feature - often including a MCVE label Jan 24, 2020
@sagetherage sagetherage added Aluminium Release Post Mg and Pre Si and removed ZRelease-Sodium retired label labels Mar 25, 2020
@sagetherage sagetherage modified the milestones: Approved, Aluminium Jul 29, 2020
@ScriptAutomate
Copy link
Contributor

I accidentally opened a duplicate about this! Copy/paste of what I had:


The salt/utils/openstack/neutron.py utils module says it is being deprecated, and/or that the salt/modules/neutron.py execution module is being deprecated? It has a warn_until() message specifying Aluminium. It says it is being replaced by the salt/modules/neutronng.py execution module.

"""
Set up neutron credentials
"""
salt.utils.versions.warn_until(
"Aluminium",
(
"The neutron module has been deprecated and will be removed in {version}. "
"Please update to using the neutronng module"
),
)

This was included in the output of a query using the following grep command from root of the repo:

grep -Rn "warn_until" -A1 | egrep -i "Alu" | egrep -v "_build|salt.7|deprecations.rst"

@sagetherage sagetherage added the P1 Priority 1 label May 7, 2021
@sagetherage sagetherage added Sulfur v3006.0 release code name and version and removed Silicon v3004.0 Release code name labels Aug 23, 2021
@sagetherage sagetherage modified the milestones: Silicon, Sulphur Aug 23, 2021
@cmcmarrow
Copy link
Contributor

cmcmarrow commented Nov 21, 2022

pillar/neutron.py
modules/neutron.py

Need work.
openstack/neutron.py is OOP as neutronng is "functional". Method names do not line up with function names and args are different. The biggest difference is the way you are expected to authenticate. It seems we need to rename functions that use this module and handle the new way they authenticate.

@cmcmarrow
Copy link
Contributor

pillar/neutron.py is the only once that needs a port pillar/neutron.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Deprecation P1 Priority 1 Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants