-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win_pkg.install failing due to calls for missing missing/incorrect registry entries #53955
Comments
What account is the |
It is running under the local administrator account. |
@breshead I was able to replicate the issue with the log messages. The above PR's should take care of that. I don't think it fixes the |
@breshead Would it be possible to get the stacktrace for the |
I am having a very similar issue @twangboy
|
@twangboy : Found the WindowsError, it was while installing JRE
|
In addition, I have finally figured out that the 'silent fail' that I thought was occurring was really just Salt saying "Already installed" as demonstrated below (Same behavior on Linux). Isn't it supposed to say something like "Already Installed"? Am I dreaming that up or did it used to be that way?
|
@breshead |
With your regards to the empty dictionary... That is a valid return in Salt. It was confusing to me at first when I was learning salt. I agree, coming from Windows world, I would expect to see something saying that it was successful and already installed... I think I had some code in at one point to that effect. But it's a change to the API, so I had to revert it. This brings Salt on Windows behavior in line with Salt on Linux. |
It should only hit that code if you're doing some sort of |
@twangboy here is the package sls.
The user is 'csuser' which is a local admin on the machine. There is no 'runas' in the package sls, but in the state file from which it is called..
As an aside, any critique on how I am making these calls or organizing things would be appreciated as well. |
The runas is required because the "SYSTEM" user which salt runs as by default does not have access to the gui and so the installer hangs even though we specifically say to run silent (no gui interactions). |
Looks like you have to use a config file to install silently with jre8. The To do that properly, you'll need to host the binary with the config and use the Populate config file (
Package definition
State
You may have to experiment a little to get the path to the config right. It may not like Something like that |
This worked and I am able to get rid of the 'runas'. Does this mean the issue is resolved or we just don't care anymore because I'm not using 'runas'? :) New package.sls
Config File:
And the install state goes to your example.. |
Maybe it was throwing the error because I was running the state from salt-call as the same admin that the 'runas' uses. Could that be it? |
You can run salt-call by hand as any one with windows admin to install software. Far as I am aware runas on windows needs special windows permissions. You can use salt-call to install software which requires GUI feed back but you need to be logon and run it by hand, so you can interact with the GUI.
|
@twangboy re: You know where the error is coming from, otherwise you would not have been able to deduce i.e. Is this complete or is there more work to do? |
With the biggest part of this issue mitigated it does not look like anyone cares about the rest. I know I don't and I hate to have clutter build up so I am closing this. The only unsolved part is why salt throws the |
Description of Issue
calls to pkg.install fail silently or with error:
Or in debug mode with a variant of this registry key issue
Setup
My package sls files specify local downloads for packages but the problem appears to be the fact that none of the registry keys that it searches in are valid..
Running
reg query
on each of the registry entries shown in the DEBUG verified that it did not exist.Steps to Reproduce Issue
From Master
From Minion
From Minion with -l debug
Produces
Versions Report Master
Master and Minion running same version..
Salt Version:
Salt: 2019.2.0
Dependency Versions:
cffi: Not Installed
cherrypy: Not Installed
dateutil: 1.5
docker-py: Not Installed
gitdb: 0.5.4
gitpython: 0.3.2 RC1
ioflo: Not Installed
Jinja2: 2.7.2
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: 0.9.1
msgpack-pure: Not Installed
msgpack-python: 0.4.6
mysql-python: 1.2.3
pycparser: Not Installed
pycrypto: 2.6.1
pycryptodome: Not Installed
pygit2: Not Installed
Python: 2.7.6 (default, Nov 13 2018, 12:45:42)
python-gnupg: 0.3.6
PyYAML: 3.10
PyZMQ: 14.4.0
RAET: Not Installed
smmap: 0.8.2
timelib: Not Installed
Tornado: 4.2.1
ZMQ: 4.0.5
System Versions:
dist: Ubuntu 14.04 trusty
locale: UTF-8
machine: x86_64
release: 3.13.0-74-generic
system: Linux
version: Ubuntu 14.04 trusty
Versions Report Minion
xxx@HEDT8 C:\salt>salt-call --versions-report
Salt Version:
Salt: 2019.2.0
Dependency Versions:
cffi: 1.11.5
cherrypy: 17.4.1
dateutil: 2.7.5
docker-py: Not Installed
gitdb: 2.0.5
gitpython: 2.1.10
ioflo: Not Installed
Jinja2: 2.10
libgit2: Not Installed
libnacl: 1.6.1
M2Crypto: Not Installed
Mako: 1.0.7
msgpack-pure: Not Installed
msgpack-python: 0.5.6
mysql-python: Not Installed
pycparser: 2.19
pycrypto: 2.6.1
pycryptodome: Not Installed
pygit2: Not Installed
Python: 2.7.15 (v2.7.15:ca079a3ea3, Apr 30 2018, 16:30:26) [MSC v.1500 64 bit (AMD64)]
python-gnupg: 0.4.3
PyYAML: 3.13
PyZMQ: 17.1.2
RAET: Not Installed
smmap: 2.0.5
timelib: 0.2.4
Tornado: 4.5.3
ZMQ: 4.2.5
System Versions:
dist:
locale: cp1252
machine: AMD64
release: 7
system: Windows
version: 7 6.1.7601 SP1 Multiprocessor Free
The text was updated successfully, but these errors were encountered: