Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #49746 to master #57139

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Conversation

alexey-zhukovin
Copy link
Contributor

What does this PR do?

Port #49746 to master

@alexey-zhukovin alexey-zhukovin requested a review from a team as a code owner May 7, 2020 19:03
@ghost ghost requested review from twangboy and removed request for a team May 7, 2020 19:03
@sagetherage sagetherage added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label May 12, 2020
@twangboy twangboy removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Nov 8, 2022
twangboy
twangboy previously approved these changes Nov 8, 2022
@twangboy twangboy added the Sulfur v3006.0 release code name and version label Nov 8, 2022
@twangboy twangboy added this to the Sulphur v3006.0 milestone Nov 8, 2022
These tests exhibit the buggy behavior in certain boto versions.
This is a workaround because there is/was a bug in boto (see
boto/boto#3061 and boto/boto#2882 for more info) where VPCs were a list
with multiple, or a dict with one VPC. Now it won't matter if the return
is a dict or a list, we'll correctly process it.
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (I mean, I wrote the tests, but... still, 👍 )

@Ch3LL Ch3LL merged commit 78df3f2 into saltstack:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master-port Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants