Fixes bug in modules/pillar.py

[tommygrumheden]

What does this PR do?

The method obfuscate needs **kwargs in parameters so its able to use items() fully, as intended.
This fixes that problem.

No tests / changelog / docs supplied in PR.

What issues does this PR fix or reference?

Fixes: No issue created.

Previous Behavior

ERROR executing 'pillar.obfuscate': The following keyword arguments are not valid: saltenv=XXX

New Behavior

saltenv works.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on Freenode
• SaltStack YouTube channel
• SaltStackInc Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[garethgreenaway]

@tommygrumheden What is the reason for the change blindly accepting kwargs instead of specific keyword arguments?

[tommygrumheden]

@tommygrumheden What is the reason for the change blindly accepting kwargs instead of specific keyword arguments?

Hi @garethgreenaway
Sincerely I don't remember. And probably no good reason for using kwargs other that it quickly fixed our problems with saltenv. :)

[garethgreenaway]

@tommygrumheden Thanks. I see why this is needed and it looks like we include it in other functions in the pillar module. I added a quick test to ensure that kwargs such as saltenv are passed along to pillar.items where it's used.

[welcome]

Congratulations on your first PR being merged! 🎉

[tommygrumheden]

@tommygrumheden Thanks. I see why this is needed and it looks like we include it in other functions in the pillar module. I added a quick test to ensure that kwargs such as saltenv are passed along to pillar.items where it's used.

Thanks for fixing a test! Happy to be contributing :) :)