Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] saltify driver still expects Impacket #62101

Closed
2 of 6 tasks
whytewolf opened this issue May 24, 2022 · 3 comments · Fixed by #62840
Closed
2 of 6 tasks

[BUG] saltify driver still expects Impacket #62101

whytewolf opened this issue May 24, 2022 · 3 comments · Fixed by #62840
Assignees
Labels
Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE P2 Priority 2 Regression The issue is a bug that breaks functionality known to work in previous releases.

Comments

@whytewolf
Copy link
Collaborator

Description
within the documentation at https://docs.saltproject.io/en/latest/topics/cloud/windows.html we say that impacket is depreciated in 3001. however the saltify cloud driver still requires this package. and will not deploy if it is not installed.

Setup
https://github.com/saltstack/salt/blob/master/salt/cloud/clouds/saltify.py#L343-L345
for more info.

Please be as specific as possible and give set-up details.

  • on-prem machine
  • VM (Virtualbox, KVM, etc. please specify)
  • VM running on a cloud service, please be explicit and add details
  • container (Kubernetes, Docker, containerd, etc. please specify)
  • or a combination, please be explicit
  • jails if it is FreeBSD

Steps to Reproduce the behavior
Try to use the saltify cloud driver on a system that doesn't have impacket

Expected behavior
salt-cloud uses alternatives instead of failing.

@whytewolf whytewolf added Bug broken, incorrect, or confusing behavior needs-triage labels May 24, 2022
@xeacott xeacott mentioned this issue Oct 7, 2022
3 tasks
@xeacott xeacott added Regression The issue is a bug that breaks functionality known to work in previous releases. Confirmed Salt engineer has confirmed bug/feature - often including a MCVE P2 Priority 2 and removed needs-triage labels Oct 7, 2022
@xeacott xeacott self-assigned this Oct 7, 2022
@xeacott
Copy link
Contributor

xeacott commented Oct 7, 2022

Technically a regression since this caused new failures on salt-master service startup (as of python3.9 and impacket==0.10.0) which haven't been caused before. This became an issue for SSE.

@Philip-A-Fry
Copy link

This is still an issue in Salt 3005.3 (with Aria Automation Config).

@whytewolf
Copy link
Collaborator Author

This is still an issue in Salt 3005.3 (with Aria Automation Config).

3005.x is CVE only branch. bug fixes will not be released for it. this fix went into 3006.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE P2 Priority 2 Regression The issue is a bug that breaks functionality known to work in previous releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants