-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misplaced periods in tls #62139
Fix misplaced periods in tls #62139
Conversation
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.3s - exit code: 1 Thanks again! |
When giving something like "/path/to/some/file.crt" it's incorrect to say "/path/to/some/file.crt." if the extension is not actually `.crt.`, but `.crt`. This fixes all of that in the tls module.
While we were at it we did a little bit of refactoring.
b1ca89b
to
fbe301e
Compare
When giving something like "/path/to/some/file.crt" it's incorrect to
say "/path/to/some/file.crt." if the extension is not actually
.crt.
,but
.crt
.This fixes all of that in the tls module.
I may need to make some changes to expected test outputs.
What does this PR do?
Previously it would return something like this:
But that's uh... not the filename. It's not
localhost.key.
that was generated, it'slocalhost.key
. That trailing period matters.What issues does this PR fix or reference?
Didn't create one (yet)
Previous Behavior
You'd have to double check that the filename was really
.crt
or.key
and didn't have an extra period at the end.New Behavior
Now you don't, the actual filename is what's in the quotes.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes