Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT] Replace pycurl/tornado with requests in salt.utils.http #64371

Closed
dwoz opened this issue May 26, 2023 · 4 comments
Closed

[TECH DEBT] Replace pycurl/tornado with requests in salt.utils.http #64371

dwoz opened this issue May 26, 2023 · 4 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior tech-debt

Comments

@dwoz
Copy link
Contributor

dwoz commented May 26, 2023

Having pycurl as a dependency for making web requests behind a proxy causes issues under our onedir packaging approach. Pycurl has no plans of releasing wheels meaning users will have to compile against libcurl. We have plans to migrate away from tornado anyway so it makes sense to replace pycurl and tornado with the python requests library.

@dwoz dwoz added the tech-debt label May 26, 2023
@dwoz dwoz added this to the Sulfur v3006.2 milestone May 26, 2023
@dwoz dwoz added the Bug broken, incorrect, or confusing behavior label May 26, 2023
@dwoz
Copy link
Contributor Author

dwoz commented May 26, 2023

See also #64299 and #62949

@Zpell82
Copy link

Zpell82 commented Jun 7, 2023

if this is implemented do a piece of news about it in good time, we have built proxy-minion tools using the "native" solution that would require a lot of rebuilding if implemented

@dwoz
Copy link
Contributor Author

dwoz commented Jun 14, 2023

if this is implemented do a piece of news about it in good time, we have built proxy-minion tools using the "native" solution that would require a lot of rebuilding if implemented

Can you explain more. If the proxy functionality in salt.utils.http works the same as it did before, why will that break things for you?

@dwoz
Copy link
Contributor Author

dwoz commented Jun 18, 2024

My understanding is that proxy support is now fully working again (as of 3006.8) the last issue as fixed by #66163.

@dwoz dwoz closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior tech-debt
Projects
None yet
Development

No branches or pull requests

6 participants