Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] fix: file.directory state children_only kwarg did not work #64497

Merged
merged 15 commits into from
Nov 22, 2023
Merged

[3006.x] fix: file.directory state children_only kwarg did not work #64497

merged 15 commits into from
Nov 22, 2023

Conversation

raddessi
Copy link
Contributor

@raddessi raddessi commented Jun 17, 2023 •
edited
Loading

What does this PR do?

This fixes the behavior of the children_only kwarg on the file.directory state to perform as documented.

I'm testing against 3006.1

What issues does this PR fix or reference?

Fixes: n/a

Previous Behavior

The root directory would still be modified even when children_only is set to True

New Behavior

Now it is not modified when requested.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@raddessi raddessi requested a review from a team as a code owner June 17, 2023 05:06
@raddessi raddessi requested review from MKLeb and removed request for a team June 17, 2023 05:06
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title WIP: fix: file.directory children only kwarg did not work [3006.x] WIP: fix: file.directory children only kwarg did not work Jun 17, 2023
@raddessi raddessi changed the title [3006.x] WIP: fix: file.directory children only kwarg did not work [3006.x] WIP: fix: file.directory children_only kwarg did not work Jun 17, 2023
@raddessi raddessi changed the title [3006.x] WIP: fix: file.directory children_only kwarg did not work [3006.x] WIP: fix: file.directory state children_only kwarg did not work Jun 17, 2023
@raddessi raddessi temporarily deployed to ci June 17, 2023 05:21 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 05:21 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 05:21 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 05:21 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 05:36 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 05:39 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:26 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:26 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:26 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:26 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:26 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:27 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:45 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:45 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:45 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:45 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:45 — with GitHub Actions Inactive
@raddessi raddessi temporarily deployed to ci June 17, 2023 06:45 — with GitHub Actions Inactive
@MKLeb
Copy link
Contributor

MKLeb commented Jun 17, 2023

@raddessi Looks great! I see you're planning on adding a changelog and tests, so once those are in we can review this :)

@raddessi raddessi marked this pull request as draft June 19, 2023 16:18
@raddessi raddessi changed the title [3006.x] WIP: fix: file.directory state children_only kwarg did not work [3006.x] fix: file.directory state children_only kwarg did not work Jun 20, 2023
@raddessi raddessi requested a review from s0undt3ch November 21, 2023 19:40
@raddessi
Copy link
Contributor Author

Test failures seem to be unrelated

@s0undt3ch s0undt3ch merged commit b064443 into saltstack:3006.x Nov 22, 2023
754 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@Ch3LL Ch3LL Ch3LL left review comments

@MKLeb MKLeb Awaiting requested review from MKLeb

@dmurphy18 dmurphy18 Awaiting requested review from dmurphy18

@whytewolf whytewolf Awaiting requested review from whytewolf

@twangboy twangboy Awaiting requested review from twangboy

Assignees
No one assigned
Labels
Sulfur v3006.4 test:full Run the full test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@raddessi @MKLeb @s0undt3ch @whytewolf @Ch3LL @twangboy @dmurphy18 @nicholasmhughes