[master] Prevent possible KeyError exception on calling salt.utils.user.get_group_dict #64599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
for the user having improper duplicate group
vzhestkov
force-pushed
the
handle-keyerror-on-grp.getgrnam
branch
from
802d1c3 to
0fbfdc8
Compare
Merged
3 tasks
Ch3LL
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes: #62377 (the fix was merged already) with #62378, but this change is addressing specific corner case when the user has imporper duplicate of the group.
Steps to reproduce the issue:
Add the following entry to
/etc/group:And set
group: files compatin/etc/nsswitch.confNote: it's not a proper configuration, but a way to reproduce the issue appearing on some of the system having NIS configured.
Previous Behavior
Possible
KeyErrorexception on callingsalt.utils.user.get_group_dictif user has improper duplicate group assigned.New Behavior
Ignoring such group entry.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.