Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PubChannel not closing zeromq connection #65464

Closed
dwoz opened this issue Oct 25, 2023 · 0 comments
Closed

[BUG] PubChannel not closing zeromq connection #65464

dwoz opened this issue Oct 25, 2023 · 0 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior Transport

Comments

@dwoz
Copy link
Contributor

dwoz commented Oct 25, 2023

Description

3006.x

AsyncReqChannels do not have __del__ we should be calling close explicitly (or using a context manager) instead.

salt/salt/channel/client.py

Lines 555 to 567 in 38725e2

req_channel = AsyncReqChannel.factory(self.opts)
try:
yield req_channel.send(load, timeout=60)
except salt.exceptions.SaltReqTimeoutError:
log.info(
"fire_master failed: master could not be contacted. Request timed"
" out."
)
except Exception: # pylint: disable=broad-except
log.info("fire_master failed", exc_info=True)
finally:
# SyncWrapper will call either close() or destroy(), whichever is available
del req_channel

@dwoz dwoz added Bug broken, incorrect, or confusing behavior needs-triage and removed needs-triage labels Oct 25, 2023
@dwoz dwoz self-assigned this Oct 25, 2023
@dwoz dwoz added this to the Sulfur v3006.5 milestone Dec 18, 2023
@dwoz dwoz closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Transport
Projects
None yet
Development

No branches or pull requests

2 participants