Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation for network bonding config #7186

Closed
je9000 opened this issue Sep 11, 2013 · 8 comments
Closed

Incorrect documentation for network bonding config #7186

je9000 opened this issue Sep 11, 2013 · 8 comments
Labels
Documentation Relates to Salt documentation
Milestone

Comments

@je9000
Copy link

je9000 commented Sep 11, 2013

In order to set the bonding xmit_hash_policy setting, the documentation states the xmit_hash_policy network setting should be used. However, modules/rh_ip.py uses the setting named hashing-algorithm in order to set the xmit_hash_policy for the bond. Either the code or the documentation should be changed to reflect the other.

Using salt 0.16.3

@basepi
Copy link
Contributor

basepi commented Sep 12, 2013

Thanks for pointing out this discrepancy.

@basepi basepi modified the milestones: Helium, Hydrogen Release Feb 4, 2014
@basepi basepi modified the milestones: Approved, Helium Apr 21, 2014
@stale stale bot added the stale label Jul 10, 2017
@stale
Copy link

stale bot commented Jul 10, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@abh
Copy link
Contributor

abh commented Jul 10, 2017

The documentation and code are still mismatched:

$ git grep xmit_hash_policy
doc/man/salt.7:    \- xmit_hash_policy: layer2
salt/modules/debian_ip.py:        'xmit_hash_policy': 'layer2',
salt/modules/debian_ip.py:            bond.update({'xmit_hash_policy': opts['hashing-algorithm']})
salt/modules/debian_ip.py:            bond.update({'xmit_hash_policy': opts['hashing-algorithm']})
salt/modules/rh_ip.py:    'ad_select', 'xmit_hash_policy', 'arp_validate',
salt/modules/rh_ip.py:        'xmit_hash_policy': 'layer2',
salt/modules/rh_ip.py:            bond.update({'xmit_hash_policy': opts['hashing-algorithm']})
salt/modules/rh_ip.py:            bond.update({'xmit_hash_policy': opts['hashing-algorithm']})
salt/states/network.py:        - xmit_hash_policy: layer2

@stale stale bot removed the stale label Jul 10, 2017
@stale
Copy link

stale bot commented Jul 10, 2017

Thank you for updating this issue. It is no longer marked as stale.

@stale
Copy link

stale bot commented Nov 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Nov 14, 2018
@basepi
Copy link
Contributor

basepi commented Nov 14, 2018

@saltstack/team-triage

@stale
Copy link

stale bot commented Nov 14, 2018

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Nov 14, 2018
@rallytime
Copy link
Contributor

@MTecknology You might be interested in fixing up this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Relates to Salt documentation
Projects
None yet
Development

No branches or pull requests

5 participants