Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.wait_for_successful_query module doesn't support 'request_interval' #53738

Closed
Oloremo opened this issue Jul 6, 2019 · 2 comments
Closed
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Milestone

Comments

@Oloremo
Copy link
Contributor

Oloremo commented Jul 6, 2019

Description of Issue

There is a slight difference between http.wait_for_successful_query state and module.
State does support request_interval kwargs while module doesn't.

Running this module without this feature creates a http connections flood since it trying to repeat http connection as soon as possible.

Why don't I just use a state? Well, first of all I think it's inconsistency which needs to be fixed. Second, I'm trying to combine loop.until with http.wait_for_successful_query to be able to parse the serialized output of http endpoints since match feature of http utils is not good for that, and I get a http connection flood.

Steps to Reproduce Issue

You can run it like:
salt-call http.wait_for_successful_query http://127.0.0.1:7777 wait_for=10 -l debug
And just check how many http connection will be executed.

While using it as a state you can throttle this by request_interval kwargs.

Versions Report

I'm using 2019.02 but all version are affected.

@cmcmarrow cmcmarrow added the Feature new functionality including changes to functionality and code refactors, etc. label Jul 9, 2019
@cmcmarrow
Copy link
Contributor

Thanks for the Featrue/Change request @Oloremo.

@Oloremo
Copy link
Contributor Author

Oloremo commented Dec 23, 2019

Feature merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Development

No branches or pull requests

2 participants