Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build continues even when next build fails #168

Open
dac09 opened this issue Apr 7, 2021 · 0 comments
Open

Build continues even when next build fails #168

dac09 opened this issue Apr 7, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dac09
Copy link

dac09 commented Apr 7, 2021

Version tested with: 6.0.6

Issue

If I have errors in my renderer code, nextron continues packaging even when next build fails

ERROR in ./main/services/window.service.ts
Module not found: Error: Can't resolve '@common/types/AppEvents' in '/xxx/services'
 @ ./main/services/window.service.ts 19:0-72 21:17-29 24:17-32
 @ ./main/background.ts
[nextron] Packaging - please wait a moment

I suspect this is to do with execa options here: https://github.com/saltyshiomix/nextron/blob/master/lib/nextron-build.ts#L60

The build error seems to happen in webpack compilation:

await execa('node', [path.join(__dirname, 'webpack.config.js')], execaOptions);

If I had to guess this process doesn't exit with error code 1 on error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants