Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfortunate peer dependency on babel when unit testing #40

Open
sam-goodwin opened this issue Aug 17, 2019 · 1 comment
Open

Unfortunate peer dependency on babel when unit testing #40

sam-goodwin opened this issue Aug 17, 2019 · 1 comment
Labels
runtime Runtime code such as Lambda, EC2, ECS

Comments

@sam-goodwin
Copy link
Owner

Looks like @aws-cdk/assert requires babel-jest? Unit tests of the examples package (and therefore any consumer of punchcard) break without the following devDependencies:

"@babel/core": "^7.4.5",
"babel-core": "^7.0.0-bridge.0",

See #38
@sam-goodwin sam-goodwin added the runtime Runtime code such as Lambda, EC2, ECS label Aug 17, 2019
@sam-goodwin
Copy link
Owner Author

Also probably related to the janky way we use webpack to bundle lambdas: #35

@sam-goodwin sam-goodwin mentioned this issue Aug 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
runtime Runtime code such as Lambda, EC2, ECS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sam-goodwin