Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.1.4 regression. Crash on missing uv property #33

Closed
altavir opened this issue Jul 11, 2021 · 3 comments · Fixed by #34 or #36
Closed

3.1.4 regression. Crash on missing uv property #33

altavir opened this issue Jul 11, 2021 · 3 comments · Fixed by #34 or #36
Labels
bug Something isn't working

Comments

@altavir
Copy link

altavir commented Jul 11, 2021

The same as #2 again.
@manthrax
Copy link
Collaborator

@altavir working on it...

@samalexander samalexander mentioned this issue Jul 12, 2021
Merged
@samalexander
Copy link
Owner

Fix released in v3.1.5

@altavir
Copy link
Author

altavir commented Jul 14, 2021

Does not seem to fix the problem. The problem is in those lines: https://github.com/Jiro-Digital/three-csg-ts/blob/70b6258138e513719b563dc8bfb326e379d0a7d4/src/CSG.ts#L58-L59. If the input geometry does not define uvs, it crashes. Please reopen.

@samalexander samalexander reopened this Jul 14, 2021
@samalexander samalexander mentioned this issue Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@manthrax @samalexander @altavir