Non-idiomatic use of cancellation token parameters

[rjgotten]

The IDistributedLockFactory interface uses a non-standard approach where a CancellationToken? typed parameter is assigned null.

RedLock.net/RedLockNet.Abstractions/IDistributedLockFactory.cs

Line 39 in dcfe373

IRedLock CreateLock(string resource, TimeSpan expiryTime, TimeSpan waitTime, TimeSpan retryTime, CancellationToken? cancellationToken = null);

The standard approach is CancellationToken cancellationToken = default which is consistent with CancellationToken.None - i.e. a token that will never cancel. It seems that the default RedLockFactory implementation already is unncessarily implementing this logic by hand using a ?? null-coalescence operator, e.g.

RedLock.net/RedLockNet.SERedis/RedLockFactory.cs

Line 130 in dcfe373

cancellationToken ?? CancellationToken.None);

Having this as part of the interface will poison-pill any other implementations of the interface as well as all call sites into this non-standard, non-idiomatic approach to cancellation tokens as well.

Just don't.