Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce copying when serializing and deserializing #26

Open
samcrow opened this issue Mar 31, 2023 · 0 comments
Open

Reduce copying when serializing and deserializing #26

samcrow opened this issue Mar 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@samcrow
Copy link
Owner

samcrow commented Mar 31, 2023

The current transmit code allocates a temporary buffer for each outgoing transfer and serializes the transfer there before splitting it into frames.

The current receive code does something similar: it collects the payloads of all frames into a buffer and then deserializes from the buffer.

It might be more efficient to serialize directly into frames, but that would make the code more complex.

@samcrow samcrow added the enhancement New feature or request label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant