Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No highlighting on fresh VS2017 installation #17

Open
dandy-step opened this issue Sep 24, 2017 · 21 comments
Open

No highlighting on fresh VS2017 installation #17

dandy-step opened this issue Sep 24, 2017 · 21 comments

Comments

@dandy-step
Copy link

I've been reading the previous issues and trying every solution, including disabling all the other extensions and reinstalling VS2017 Community (15.3.5). The issue is that no highlighting ever appears on my shader files, and there is no nShader section under Options although "Shader Language" does appear under the Text Editor section. Enabling, disabling, and reinstalling the extension doesn't seem to do anything either, except that with the extension enabled I get no highlighting at all and with it disabled I get the basic highlighting. Opening the file through a solution, manually, or creating a new shader file results in the same thing.

The extension appears in About section, and there are no errors. Going through the activity log and searching for "nShader" yields zero results. Don't really know where to go from there.

screenshot 686

@ghost
Copy link

ghost commented Oct 10, 2017

Same issue here, VS2017 Enterprise 15.4, got the "Shader Language" title under 'Options->Text Editor', but no highlight in editor view, no 'Nshader- ...' titles under 'Options->Environment->Fonts and Colors'.

@themike10452
Copy link

Same here with VS2017 Enterprise 15.3.4

@ok4pi
Copy link

ok4pi commented Nov 6, 2017

Same issue on Community 15.4.2. Hoping this gets fixed soon.

@marshal-it
Copy link

can used for vs2017?

@felixkraas
Copy link

Same here,
VS 15.4.4
NShader 2.4

@MStachowicz
Copy link

MStachowicz commented Nov 26, 2017

Fixed mine by manually adding the file extensions under Options->Text Editor->File Extension.
This is on VS community 2017 5.4.4/NShader 2.4

pxpm3eswt96jxjkpf58uow

@bakeunbin
Copy link

MStachowicz Could you tell us what version of VS you are using? I have tried that, but it didn't fix the problem for me.

@MStachowicz
Copy link

MStachowicz commented Nov 26, 2017

@Schmerzmittel Hey VS is community 2017 15.4.4 using NShader 2.4

@bakeunbin
Copy link

bakeunbin commented Nov 26, 2017

Okay, guys. I think I figured out something. My VS was in different language. When I changed it to English, the shader started to work again. I don't know how many of you are using VS in different language, but if you are using VS in different language, maybe you can change it to English.

@DianaNites
Copy link

Same issue here. Visual Studio is using English.

Mapping the extensions to NShader did not work.

@rienik
Copy link

rienik commented Dec 3, 2017

Same here, the .fs file extension had a bit of highlighting before using NShader, after adding .fs to the list it became just plain white text in the editor.

@rienik
Copy link

rienik commented Dec 3, 2017

I checked the install log and it said:
Skipping 'C:\Users\<username>\AppData\Local\Microsoft SDKs' as if it doesn't exist The extension with ID 'NShader.51a01e9d-eb56-4ee2-a9fd-8212bf6bf2b1' is not installed to Visual Studio Community 2017.
So I added the folder 'Microsoft SDKs' to '\AppData\Local\', reinstalled it, and it worked! Although the install log still said:
The extension with ID 'NShader.51a01e9d-eb56-4ee2-a9fd-8212bf6bf2b1' is not installed to Visual Studio Community 2017.

@DianaNites
Copy link

@rienik Thanks, i can confirm that fixed the issue for me as well.

@johannesugb
Copy link

johannesugb commented Dec 5, 2017

@rienik Dang, that works indeed! Maybe some additional info: Highlighting used to work until I updated Visual Studio 2017 some days ago. Also installed the latest Windows SDK in addition to previously installed Windows SDKs. Afterwards highlighting was not working anymore.

@themike10452
Copy link

@rienik your solution works for me as well. Thanks.

@DianaNites
Copy link

DianaNites commented Dec 29, 2017

The issue seems to have reappeared for me. Highlighting has disappeared

@johannesugb
Copy link

johannesugb commented Jan 9, 2018

Same here: the issue has reappeared even though Microsoft SDKs folder is still there and I could not see any errors in the install log.

Currently, it is working again (by accident?). I have uninstalled and installed it three times in a row. I have no idea, why it behaves that way. Does Visual Studio write to a logfile about problems with extensions?

@johannesugb
Copy link

Happened again after Windows update KB4074588. Microsoft SDKs folder was gone => re-created it, re-installed NShader => worked again.

@ForeverZer0
Copy link

I am rather certain this is extension is simply broken on VS2017.

  • Brand new update to VS2017 Enterprise 15.7.3
  • Created "Microsoft SDKs" folder in my "AppData/Local" directory
  • Installed latest NShader VSIX (2.4)
  • Added "frag" and "vert" to open with Nshader in "Tools->Options->Text Editor->File Extension"
  • Open ".frag" and ".vert" file in VS after restarting and.... NOTHING! No highlighting, no nothing. Might as well just be a regular text document.

@samizzo
Copy link
Owner

samizzo commented Jun 5, 2018 via email

@johannesugb
Copy link

Thanks for you work and you comments, @samizzo !
HlslTools do not provide GLSL highlighting, do they?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests