Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context lines shouldn't be tagged #20

Open
elzibubble opened this issue Jun 17, 2015 · 0 comments
Open

Context lines shouldn't be tagged #20

elzibubble opened this issue Jun 17, 2015 · 0 comments

Comments

@elzibubble
Copy link

If I run sack with -C3, I get output like:

/home/lealexis/w/nova/nova/objects/fixed_ip.py
[1] 122-        if expected_attrs is None:
[2] 123-            expected_attrs = []
[3] 124-        get_network = 'network' in expected_attrs
[4] 125:        db_fixedip = db.fixed_ip_get(context, id, get_network=get_network)
[5] 126-        return cls._from_db_object(context, cls(context), db_fixedip,
[6] 127-                                   expected_attrs)
[7] 128-

Only [4] is follow-able though.

It'd be better if only the middle line was tagged and followable. This would help prevent the tag numbers growing so quickly.

If you fix this, please ensure context lines are properly indented so the code aligns correctly.

Also remember that two context sections can run together. In this case, both hits should be numbered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant