fixes zendframework#6812 : Zend\Paginator\Adapter\DbSelect::getItems should return array

Author: samsonasik

library/Zend/Paginator/Adapter/DbSelect.php

@@ -87,7 +87,12 @@ public function getItems($offset, $itemCountPerPage)
         $resultSet = clone $this->resultSetPrototype;
         $resultSet->initialize($result);
 
-        return $resultSet;
+        $items = array();
+        foreach($resultSet as $key => $result) {
+            $items[] = $result;
+        }
+
+        return $items;
     }
 
     /**

tests/ZendTest/Paginator/Adapter/DbSelectTest.php

@@ -74,7 +74,7 @@ public function testGetItems()
         $this->mockSelect->expects($this->once())->method('limit')->with($this->equalTo(10));
         $this->mockSelect->expects($this->once())->method('offset')->with($this->equalTo(2));
         $items = $this->dbSelect->getItems(2, 10);
-        $this->assertInstanceOf('Zend\Db\ResultSet\ResultSet', $items);
+        $this->assertEquals(array(), $items);
     }
 
     public function testCount()

tests/ZendTest/Paginator/Adapter/DbTableGatewayTest.php

@@ -64,7 +64,7 @@ public function testGetItems()
              ->will($this->returnValue($mockResult));
 
         $items = $this->dbTableGateway->getItems(2, 10);
-        $this->assertInstanceOf('Zend\Db\ResultSet\ResultSet', $items);
+        $this->assertEquals(array(), $items);
     }
 
     public function testCount()
@@ -97,7 +97,7 @@ public function testGetItemsWithWhereAndOrder()
              ->will($this->returnValue($mockResult));
 
         $items = $this->dbTableGateway->getItems(2, 10);
-        $this->assertInstanceOf('Zend\Db\ResultSet\ResultSet', $items);
+        $this->assertEquals(array(), $items);
     }
 
     public function testGetItemsWithWhereAndOrderAndGroup()
@@ -118,7 +118,7 @@ public function testGetItemsWithWhereAndOrderAndGroup()
              ->will($this->returnValue($mockResult));
 
         $items = $this->dbTableGateway->getItems(2, 10);
-        $this->assertInstanceOf('Zend\Db\ResultSet\ResultSet', $items);
+        $this->assertEquals(array(), $items);
     }
 
     public function testGetItemsWithWhereAndOrderAndGroupAndHaving()
@@ -140,6 +140,6 @@ public function testGetItemsWithWhereAndOrderAndGroupAndHaving()
             ->will($this->returnValue($mockResult));
 
         $items = $this->dbTableGateway->getItems(2, 10);
-        $this->assertInstanceOf('Zend\Db\ResultSet\ResultSet', $items);
+        $this->assertEquals(array(), $items);
     }
 }