-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish "unstable" build on each push to master? #175
Comments
I am indeed interested in this. I haven't gotten a chance to look into it yet much though. |
Have a suggestion when I get back in next week. Thanks for tracking this! N Thumb typed for added typos
|
@nh13 What was your suggestion for this? |
Responded in person, posting for posterity. |
I am also interested in this. What needs to happen to make this happen soon? |
I'll touch base on Monday. Setup is on the same order of magnitude as the existing Maven Central releases. One can publish pre-releases and/or snapshots. As htsjdk is foss, the repo can be sonatype, or use our artifactory.broadinstitute.org. Search "artifactory" on the dsde wiki for a little more info for now. |
Looking fwd to this happening! We are in need of this right now for the issue referenced above. |
Any word on this? |
I pinged GG last week with the following:
Once the above is resolved, that person just needs to point the build at the right |
By the way, if that mystery publisher hasn't already setup a shared credential that can be put into travis/jenkins/etc., it should be possible to create one with a few steps. Here are a few example links I came across that touched on somewhat similar setups:
If interested parties -- and the person(s) who owns htsjdk publishing -- want to throw something in my calendar, happy to discuss more. |
Oops, sorry for the radio silence, that's my bad. To answer the questions, I don't know who currently pushes releases but I thought it might be @jacarey; and I assume we would want the -SNAPSHOT versioning. |
I'm strongly in support of individual versions per commit. |
I happily defer to the expertise of my learned colleague |
@kshakir thanks for the pointer to the DSDE wiki. It turns out it's rather easy to publish to the artifactory thanks to your tutorial. I think snapshots would be OK if they were per branch. I think that ideally, builds should be entirely repeatable, and snapshots break that assumption. |
So I was mistaken about Sonatype hosting pre-releases that one could take down after release. I thought there was an intermediary step between the OSSRH repo, and the HTSJDK pre-release being pushed to Central. It turns out the intermediary step is before the artifact reaches the OSSRH release repo.
-- http://central.sonatype.org/pages/releasing-the-deployment.html
-- http://central.sonatype.org/pages/ossrh-guide.html#accessing-repositories I'm pretty sure we want the ability to take down these pre-releases. So unless there are any objections, I'll ping @mmonnar via a help ticket for next steps towards hosting just the pre-releases on our publicly accessible, but internally maintained repo. The plan always was for pre-release consumers to add a new repo to their builds, but instead of OSSRH it'll be https://artifactory.broadinstitute.org. |
Credentials are now available as environment variables for "local" builds, aka not in pull requests. The next steps to be done are wiring a script (sbt, bash, or otherwise) to use these environment variables, and publish the artifacts on each successful build if the I'm juggling a number of other tasks at the moment, so please continue to ping, or even better google away and submit a patch for review. FYI the variables one will need are for configuring sbt/ivy credentials are:
The publish endpoints are:
Btw, upon further thought, I'm thinking perhaps to make it unambiguous to users, htsjdk should use both git and snapshot versioning: |
@kshakir are you going to have any time in the immediate future to put into this? There's a GATK issue I was going to assign to one of our assoc. comp bios that needs an htsjdk update and it would be a little more approachable if it didn't need a merge to htsjdk master in the middle. |
First build is up, and should work for maven, sbt, gradle, ivy, leiningen, et al. I believe this issue is complete. |
And our first 1.138 snapshot too! Looks good @kshakir |
Thanks @kshakir! |
(related to #115)
There's been some interest in having an "unstable" jar published to Maven on each push to master, in addition to the "stable" release every ~2 weeks.
This would be useful for larger projects that depend on HTSJDK where a few members of the project want to contribute features to HTSJDK, without everyone having to worry about syncing their local versions of HTSJDK before building the other project.
I'm not sure on the best way to do this. We'd also need to make it very clear that it's for experimental use only. In the short term, a fork might be an easier solution, but let's keep this on the radar.
@lbergelson @akiezun @droazen are interested in this.
The text was updated successfully, but these errors were encountered: