Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] All captions are highlighted as selected #452

Closed
1 task
Dananji opened this issue Mar 14, 2024 · 2 comments
Closed
1 task

[BUG] All captions are highlighted as selected #452

Dananji opened this issue Mar 14, 2024 · 2 comments
Assignees
Labels
bug 🐛 Something isn't working player Changes/fixes in player component

Comments

@Dananji
Copy link
Collaborator

Dananji commented Mar 14, 2024

Description

In the captions menu in Ramp, all captions are shown as selected even though only one caption is selected.
Screenshot 2024-03-14 at 4 43 50 PM

Environment

  • All desktop browsers (Safari, Firefox, Chrome)
  • Chrome and Safari in iPad
  • Chrome in Android

Done Looks Like

  • Only the selected caption is shown as selected on player initialization

Notes

Ramp only sets default attribute to true for the first caption in the list, but Video.js makes 2 passes over the text tracks list and marks multiple captions as selected in the captions menu when initializing.

@Dananji Dananji added bug 🐛 Something isn't working player Changes/fixes in player component labels Mar 14, 2024
@Dananji Dananji self-assigned this Mar 18, 2024
@elynema
Copy link

elynema commented Mar 25, 2024

Test on demo site before we make a new Ramp PR.

@charumitraravi
Copy link
Collaborator

Verified this item on the Ramp demo site on Chrome and Safari browsers, on web and mobile. The fix is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working player Changes/fixes in player component
Projects
None yet
Development

No branches or pull requests

4 participants