Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spans Past Duration Do Not Display As Links in Structural Metadata #458

Closed
2 tasks
joncameron opened this issue Mar 20, 2024 · 3 comments
Closed
2 tasks
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented Mar 20, 2024

Description

Existing structure is not displaying correctly in the structural navigation component on the item page when spans go beyond the duration of the file. Spans are active like divs and not displaying as hyperlinks that navigate to that a time point in the media player.

Example: https://purl.dlib.indiana.edu/iudl/media/b68x31xp9v

Previous Investigation (see https://github.iu.edu/AvalonIU/Avalon/issues/233)

Further looking around and it looks like the integer durations were a red herring/coincidence. This item has a broken final structure link because total duration is 2912.314 and end of last segment is 2912.32. So the problem is just structure items having ends past the end of the object duration. Duration assignment and serialization is likely fine.

To Reproduce

Done Looks Like

  • Spans with end times that go beyond the duration of the stream are active as links, and selecting them seeks the player to the beginning of the span
  • Spans with begin times and end times past the duration of the stream appears as links but are a no-op (no action upon selection)

Screenshots

Screenshot 2024-03-18 at 1 43 38 PM

Screenshot 2024-03-18 at 1 44 11 PM

@joncameron
Copy link
Contributor Author

Will need to thoroughly test the structure as it shows up in the player (highlighting) to make sure it's working correctly.

@elynema
Copy link

elynema commented Mar 22, 2024

This is unlikely to affect other Avalon institutions, as most don't use structural metadata as heavily as we do at IU, so this could be pushed to next full release and cherrypicked out to MCO.

@Dananji
Copy link
Collaborator

Dananji commented Mar 27, 2024

Testing notes for done looks like criteria;

Spans with end times that go beyond the duration of the stream are active as links, and selecting them seeks the player to the beginning of the span

Test item: Last timespan in the second section in https://avalon-dev.dlib.indiana.edu/media_objects/fn106x94r/manifest.json

Spans with begin times and end times past the duration of the stream appears as links but are a no-op (no action upon selection)

Test item: Last timespan in the sample manifest in Ramp demo site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants