Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveFedora 6.7.4 doesn't work with rubydora 1.7.0 #332

Closed
jcoyne opened this issue Jan 17, 2014 · 3 comments
Closed

ActiveFedora 6.7.4 doesn't work with rubydora 1.7.0 #332

jcoyne opened this issue Jan 17, 2014 · 3 comments

Comments

@jcoyne
Copy link
Member

jcoyne commented Jan 17, 2014 

 NoMethodError:
   undefined method `new_record?' for #<ActiveFedora::UnsavedDigitalObject:0x007f8f38510a58>
 # /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rubydora-1.7.0/lib/rubydora/datastream.rb:122:in `new?'
 # /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/active-fedora-6.7.4/lib/active_fedora/rdf_datastream.rb:75:in `deserialize'
@cbeer
Copy link
Member

cbeer commented Jan 17, 2014

Did the changes you make to rubydora break backwards compatibility? Shouldn't we fix it there?

@jcoyne
Copy link
Member Author

jcoyne commented Jan 17, 2014

It doesn't break anything if you are using Rubydora on its own. It only breaks because ActiveFedora are extends the rubydora classes. I've got a fix on the way.

@jcoyne
Copy link
Member Author

jcoyne commented Jan 17, 2014

This PR fixes it: #334

@jcoyne jcoyne closed this as completed Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcoyne @cbeer