Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Bulkrax identifier" custom queries & behavior doesn't belong in Hyku #903

Closed
Tracked by #86
laritakr opened this issue Jan 26, 2024 · 1 comment
Closed
Tracked by #86

Comments

@laritakr
Copy link
Contributor

laritakr commented Jan 26, 2024

Hyku has some added custom queries and conditional indexing of "bulkrax_identifier", which belong in bulkrax. The term doesn't exist on the models, so including queries and indexing isn't happing in the right place.

This code should be included in Bulkrax as part of the Valkyrization process, and removed from Hyku.

Relevant modules:

  • collection_indexer.rb & collection_resource_identifier.rb
  • hyku_indexing.rb
  • find_by_bulkrax_identifier.rb (app/services/hyrax/custom_queries/ and app/services/wings/custom_queries/)
  • find_by_bulkrax_identifier_spec.rb

Use of the term, such as adding it to models and mapping it, should also be considered and documented.

related:

@ShanaLMoore
Copy link
Contributor

done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants