Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding File to GenericFile without saving #147

Open
flyingzumwalt opened this issue Jul 13, 2015 · 3 comments
Open

Allow adding File to GenericFile without saving #147

flyingzumwalt opened this issue Jul 13, 2015 · 3 comments
Labels

Comments

@flyingzumwalt
Copy link
Member

I'm pretty sure this actually percolates down to the implementation of directly_contains in ActiveFedora.

There are lots of places where the tests were using generic_file.add_file in the setup (which adds the file object to #attached_files in memory) and then never saving the parent. Now I have to save both the parent and the contained file.

If you search for add_file within this diff of sufia-core you'll see a lot of examples of where I had to save the GenericFile:
https://github.com/projecthydra-labs/sufia-core/compare/before_cc...projecthydra-labs:migrate_to_curation_concerns

Here's one example: https://github.com/projecthydra-labs/sufia-core/compare/before_cc...projecthydra-labs:migrate_to_curation_concerns#diff-32a50de6ae2d35fbe4b024d452d3a274R11

@flyingzumwalt
Copy link
Member Author

@jcoyne @elrayle

@jrgriffiniii
Copy link
Contributor

Blocked by #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

4 participants