Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Featured Works in the Neutral Repository theme disables the Share you work button #1865

Closed
labradford opened this issue Dec 16, 2022 · 0 comments · Fixed by #1866
Closed

Comments

@labradford
Copy link
Collaborator

Descriptive summary

In Hyku main, when the Neutral Repository theme is selected, and the Featured Work feature flipper is toggled off, the Share your work button is toggled off as a side effect.

Rationale

The Share your work button is included inside the section that is toggled on/off in Featured Work. The Share you work button should be moved outside of the Featured Work section in the Neutral Repository theme files.

Expected behavior

When the Neutral Repository theme is selected, and you toggle off Featured Works, the Show your work button is not affected.

Actual behavior

When the Neutral Repository theme is selected, and you toggle off Featured Works, the Show your work button is removed.

Steps to reproduce the behavior

  1. Select the Neutral Repository theme
  2. Use the feature flipper to disable Featured Works
  3. Make sure the Share your work button still appears on the home page

Related work

Contributed from Palni/Palci project
https://gitlab.com/notch8/palni-palci/-/merge_requests/627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant