You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When editing an admin set, the view hyrax/admin/admin_sets/_form_visibility.html.erb uses @form.permission_template to construct the form allowing the user to add access. Similarly, the views hyrax/admin/admin_sets/_form_participants.html.erb and hyrax/admin/admin_sets/_form_workflow.html.erb also use @form.permission_template.
When working with Hyrax::AdministrativeSet (Valkyrie::Resource), the Hyrax::AdministrativeSetForm (Valkyrie::ChangeSet) is used. At this time, it does not support #permission_template. This error impacts Visibility, Sharing, and Workflow tabs of the admin set edit form.
Rationale
Working with AF Collections or Valkyrie Collections, the all admin set tabs on the edit form should work.
Expected behavior
Editing a Hyrax::AdministrativeSet should load the edit form, including all tabs.
Actual behavior
Editing a Hyrax::AdministrativeSet fails to load the edit form for multiple reasons. One includes the inability to load the Visibility, Sharing, and Workflow tabs because the @form object does not support the #permission_template method.
Descriptive summary
When editing an admin set, the view
hyrax/admin/admin_sets/_form_visibility.html.erb
uses@form.permission_template
to construct the form allowing the user to add access. Similarly, the viewshyrax/admin/admin_sets/_form_participants.html.erb
andhyrax/admin/admin_sets/_form_workflow.html.erb
also use @form.permission_template.When working with Hyrax::AdministrativeSet (Valkyrie::Resource), the Hyrax::AdministrativeSetForm (Valkyrie::ChangeSet) is used. At this time, it does not support
#permission_template
. This error impacts Visibility, Sharing, and Workflow tabs of the admin set edit form.Rationale
Working with AF Collections or Valkyrie Collections, the all admin set tabs on the edit form should work.
Expected behavior
Editing a Hyrax::AdministrativeSet should load the edit form, including all tabs.
Actual behavior
Editing a Hyrax::AdministrativeSet fails to load the edit form for multiple reasons. One includes the inability to load the Visibility, Sharing, and Workflow tabs because the
@form
object does not support the#permission_template
method.Steps to reproduce the behavior
Prerequisites:
Edit
/config/initializers/hyrax.rb
and set:To reproduce:
The error will occur as the edit form tries to load.
NOTE: There may be other errors once this error is resolved.
Related work
See related issues in Issue #5326 UBER: Hyrax-Valkyrization MVP
Issue #5329 is the same error for Collections
The text was updated successfully, but these errors were encountered: