Valkyrie: Hyrax::AdministrativeSet fails to delete fully

[elrayle]

Descriptive summary

When an admin set is created as a Hyrax::AdminstrativeSet and later deleted, it goes through the process without error, but fails to fully delete.

Rationale

Deleting admin sets should work whether the admin set is an Active Fedora admin set or a Valkyrie admin set.

Expected behavior

Deleting an admin set fully deletes the admin set and its access control from the data store and solr.

Actual behavior

Deleting an admin set deletes the admin set from the datastore, but fails to delete it from solr and fails to delete its access control from the datastore.

Steps to reproduce the behavior

Prerequisites:

Configure Hyrax:

1. Edit /config/initializers/hyrax.rb and set:

  config.collection_model = "Hyrax::PcdmCollection"
  config.query_index_from_valkyrie = true
  config.index_adapter = :solr_index

2. restart rails app
3. Make sure regular hyrax-development and hyrax-valkyrie-dev solr cores are running . Your core names may vary depending on how you start them and how they are configured in the app.
4. Make sure you have access to the datastore (i.e. postgres)

NOTE: For testing of nurax-pg, the solr core is typically named nurax-pg.

Create Admin Set

1. click button: New Collection
2. select type: Admin Set
3. click button: Create Collection
4. set Title: DELETE ME (or other meaningful name)
5. click Save
6. Copy the id from the URL

Verify that the admin set was created in both solr cores with q: title_tesim:DELETE ME (or similar query).
Verify that the admin set and it access control were created in the datastore.

To reproduce:

1. Navigate to: Dashboard -> Collections
2. Click on the title of the admin set you want to delete (e.g. DELETE ME)
3. click button: Delete

Verify that the admin set was deleted from both solr cores with q: title_tesim:DELETE ME (or similar query).
Verify that the admin set and it's access control were created in the datastore.

Related work

See related issues in Issue #5326 UBER: Hyrax-Valkyrization MVP
See Issue #5331 describing the same issue for Hyrax::PcdmCollection

[no-reply]

looks like this behavior should get added to the AdminSetDestroy transaction.

[jlhardes]

Unable to fully test locally using koppie since I'm not sure how to access the Postgres datastore. I can see Solr and was able to create the admin set, query for it in Solr, delete the admin set, and then verify that Solr no longer has a record for the admin set. The UI looks like everything works as it should but I can't verify that the admin set and its access control are removed from the datastore.

[gamontoya]

@rjkati Not able to verify this issue either.

[alishaevn]

we were able to verify today that this issue has already been resolved.

postgres gui (dbeaver) settings

after creating an admin set

after deleting the above admin set

[jessicahilt]

SoftServ verified.