Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentError in CollectionsController #update when updating and saving changes to logos #5483

Closed
elrayle opened this issue Mar 2, 2022 · 0 comments · Fixed by #5482
Closed

Comments

@elrayle
Copy link
Contributor

elrayle commented Mar 2, 2022

Descriptive summary

Editing logos for a branded collection raises exception ArgumentError in Hyrax::Dashboard::CollectionsController#update

Rationale

Branding should be able to be updated without errors.

Expected behavior

When editing a collections that has a logo and add a second logo, saving should add the second logo.

Actual behavior

When editing a collections that has a logo and add a second logo, saving raises an exception.

image

Steps to reproduce the behavior

Prerequisite

Create a collection with a logo.

  1. Navigate to: Dashboard -> Collections
  2. Click button: New Collection
  3. Select type: User Collection (definitely has branding enabled)
  4. Set title: BRANDED COLLECTION (or other meaningful name)
  5. Click tab: Branding
  6. Click button for logo: Choose File
  7. Select any file
  8. Click button: Save

To reproduce:

  1. Navigate to: Dashboard -> Collections
  2. Select Action beside the collection created in prerequisites
  3. Click tab: Branding
  4. To add another logo, click button for logo: Choose File
  5. Select any file
  6. Click button: Save

This will raise the exception seen in the Actual behavior section.

Related work

Issue #5470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant