Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Automatic Draper Include #770

Open
no-reply opened this issue Oct 18, 2019 · 1 comment
Open

Deprecate Automatic Draper Include #770

no-reply opened this issue Oct 18, 2019 · 1 comment

Comments

@no-reply
Copy link
Contributor

no-reply commented Oct 18, 2019

When Valkyrie::Resource#decorate is called, but there wasn't an explicit include Draper::Decoratable, it should throw a deprecation warning telling the developer to explicitly include Draper::Decoratable in their project.

Possible Implementation (needs testing)

Create a module which includes Draper::Decoratable, override #decorate in that module to throw the deprecation warning, and then include that module in Valkyrie::Resource.

Previous ticket text below.

Resource includes Draper::Decoratable by default.

Since this injects a variety of behavior (including overrides for simple operations like #== via Draper::Decoratable::Equality) that some users may want, while others may not expect. Since adding this behavior locally is as easy as include Draper::Decoratable, should Valkyrie::Resource decline to provide it by default?

@no-reply
Copy link
Contributor Author

After discussion today at Samvera Connect, I'm going to take a hack at deprecating draper inclusion.

@no-reply no-reply changed the title Extract Draper? Extract Draper Oct 22, 2019
@no-reply no-reply self-assigned this Oct 22, 2019
@tpendragon tpendragon changed the title Extract Draper Deprecate Automatic Draper Include Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant