You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When Valkyrie::Resource#decorate is called, but there wasn't an explicit include Draper::Decoratable, it should throw a deprecation warning telling the developer to explicitly include Draper::Decoratable in their project.
Possible Implementation (needs testing)
Create a module which includes Draper::Decoratable, override #decorate in that module to throw the deprecation warning, and then include that module in Valkyrie::Resource.
Previous ticket text below.
Resource includes Draper::Decoratable by default.
Since this injects a variety of behavior (including overrides for simple operations like #== via Draper::Decoratable::Equality) that some users may want, while others may not expect. Since adding this behavior locally is as easy as include Draper::Decoratable, should Valkyrie::Resource decline to provide it by default?
The text was updated successfully, but these errors were encountered:
When
Valkyrie::Resource#decorate
is called, but there wasn't an explicitinclude Draper::Decoratable
, it should throw a deprecation warning telling the developer to explicitly includeDraper::Decoratable
in their project.Possible Implementation (needs testing)
Create a module which includes
Draper::Decoratable
, override#decorate
in that module to throw the deprecation warning, and then include that module inValkyrie::Resource
.Previous ticket text below.
Resource
includesDraper::Decoratable
by default.Since this injects a variety of behavior (including overrides for simple operations like
#==
viaDraper::Decoratable::Equality
) that some users may want, while others may not expect. Since adding this behavior locally is as easy asinclude Draper::Decoratable
, shouldValkyrie::Resource
decline to provide it by default?The text was updated successfully, but these errors were encountered: