Added support for MacOS HighSierra #689

Axadiw · 2017-09-27T14:03:09Z

Changed XPC Id's that are being sent to CoreBluetooth on MacOS HighSierra

Tested everything besides:

discoverIncludedServices
broadcast
writeValue (on descriptor)
readHandle
writeHandle

Additionaly it looks like after registering on notifications, we're CoreBluetooth is sending the same ID as after requesting for characteristic value (single value, not continuous notifications). This may lead to some problems with notification registration on some characteristics.

Fixes #679 and #680

enami · 2017-09-29T03:23:11Z

lib/mac/highsierra.js

+  }.bind(this));
+};
+
+nobleBindings.on('kCBMsgId6', function(args) {


I was needed to change from kCBMsgId6 to kCBMsgId4 to catch stateChange event on my MBP running High Sierra.

xpcEvent: { "kCBMsgId": 4, "kCBMsgArgs": { "kCBMsgArgState": 5 } }

You're right, I've missed that one

Thanks

mlcloudsec · 2017-10-05T04:36:37Z

an ETL on this please?

achingbrain · 2017-10-10T07:08:37Z

Works for me, although running with DEBUG=* prints messages from yosemite-bindings instead of highsierra-bindings - this line needs changing.

Axadiw · 2017-10-10T13:48:09Z

Thanks @achingbrain - I've changed these debug messages accordingly to your suggestion

andrewjaykeller · 2017-10-13T13:42:31Z

Okay testing this branch!

vikeri · 2017-10-16T13:02:37Z

Can also verify that this works 👍

andrewjaykeller · 2017-10-16T15:15:26Z

Seems to be working good enough, as good enough, still loosing samples and we hope a switch to core Bluetooth could help!

sid9102 · 2017-10-16T19:24:06Z

Can confirm that this is working. However like @aj-ptw mentioned above it appears to be losing a lot of samples. My latency has gone from an average of 30 ms per update to 150 ms.

andrewjaykeller · 2017-10-17T00:51:03Z

I've got some hours to put towards using core bluetooth as the underlying lib with the goal to improve the notifications on select macOS computers.

I see @sandeepmistry started more-test looks like where i should pull and work from.

andrewjaykeller · 2017-10-18T15:31:43Z

Any idea when will this get merged?

taktran · 2017-10-24T17:29:02Z

This is working for me too, but it's a bit laggy. On simple scripts, it works ok with some minor lag, but with a UI, you can definitely feel it.

nisargap · 2017-11-01T18:04:08Z

This works for me on macOS High Sierra

bennesp · 2017-11-05T14:14:15Z

I run peripheral-explorer.js, and I obtained an error on line 376 of highsierra.js:

TypeError: Cannot read property 'uuid' of undefined

The line is the following:

var serviceUuid = this._peripherals[deviceUuid].services[serviceStartHandle].uuid;

I debugged a bit, and serviceStartHandle is undefined, because the args passed to that callback don't contain a kCBMsgArgServiceStartHandle
Args:

{ kCBMsgArgDescriptors: 
   [ { kCBMsgArgUUID: <Buffer 29 02>, kCBMsgArgDescriptorHandle: 15 } ],
  kCBMsgArgCharacteristicHandle: 13,
  kCBMsgArgDeviceUUID: <Buffer 6e dd ... 27 e9> }

Am I doing something wrong?

JackCurrie · 2017-11-16T02:50:08Z

Works for me on 2017 MacBook pro running high sierra version 10.13.1. Thanks!

leinelissen · 2017-11-16T12:55:20Z

Works on iMac 2015, using 10.13. Also checks out with my MacBook Pro 2017 running 10.13. Could we please merge this?

alexandrevilain · 2017-11-18T17:43:22Z

Works for me on MacBook Pro (mid 2014) running macOS version 10.13.1.
Thanks for your work !

dfrankland

Whenever trying to discover descriptors, there's an error.

dfrankland · 2017-11-19T23:14:07Z

lib/mac/highsierra.js

+nobleBindings.on('kCBMsgId87', function(args) {
+  var deviceUuid = args.kCBMsgArgDeviceUUID.toString('hex');
+  var serviceStartHandle = args.kCBMsgArgServiceStartHandle;
+  var serviceUuid = this._peripherals[deviceUuid].services[serviceStartHandle].uuid;


I consistently get a TypeError: Cannot read property 'uuid' of undefined error here.

Same here. Running examples/peripheral-explorer.js I see the TypeError: Cannot read property 'uuid' of undefined error. examples/advertisement-discovery.js runs without issue.

87 is (correctly) assigned to servicesDiscover above, and duplicated here incorrectly. We need to figure out what includedServicesDiscover's xpc id actually is

I think its 76.. Try that

gpgabriel · 2017-11-24T11:00:47Z

I'm testing this PR on macOS 10.13, I'am able to discover my device (nRF52832) and from the logs I can see that the library sends the event 45 and 46 then receives 48 but it doesn't receive 49 to change the state of the device to connected. No other events are being logged.

When using gatttool on Debian I'm able to connect to the device without any errors.

I've been looking for a dictionary to get more details about all the possible events but I couldn't find any, could you please point me somewhere to get this data?

~~EDIT: Also, most of the devices around me appear with an unknown address. (noble on Debian returns the correct addresses).~~

EDIT2: The fact that the address is unknown for most of the devices seems to be related to the fact that CoreBluetoothCache from /Library/Preferences/com.apple.Bluetooth.plist has very few items (in my case just 5).

EDIT3: I just tested this with macOS 10.12.6 and the library stays blocked in the same connecting state. CoreBluetoothCache doesn't even exists in the com.apple.Bluetooth.plist object. The only place where I've seen the library to work is on Debian.

gpgabriel · 2017-11-27T12:50:02Z

I spent many hours trying to get the library to connect to a device on macOS 10.13 using node 8.2.1/7.10.2/4.1.2 but I couldn't find any way. The peripheral object gets blocked in connecting state (no other xpc events are being emitted after that). Also, the default bluetooth device from my computer is broken (it's not recognised) so I'm using a bluetooth dongle (Asus BT400).

EDIT: I think it's the BT400 which is causing issues, it works on macOS 10.12 with an integrated (Mac mini) bluetooth chip.

hanhdt · 2017-12-01T07:50:33Z

I'm testing this PR on 10.13.1 High Sierra.
I run peripheral-explorer.js, and I obtained an error on: core-bluetooth/lib/peripheral-manager.js:41

Log is the following:

$.CBPeripheralManager.getInstanceMethod('xpcConnection:didReceiveMsg:args:').exchangeImplementations($.CBPeripheralManager.getInstanceMethod('xpcConnection:didReceiveMsg:argsSwizzled:'));

TypeError: Cannot read property 'exchangeImplementations' of null
    at Object.<anonymous> (/node_modules/core-bluetooth/lib/peripheral-manager.js:41:77)
    at Module._compile (module.js:635:30)

What am I doing wrong?

Guzmandius · 2017-12-07T06:39:35Z

Bit of a noob. But, how do I apply this specific branch. I installed the more-test branch, but i am getting yosemite-bindings. do I just modify the bindings.js and add the highsierra.js file. I appreciate the help and insight. I am trying to add the bluetooth module for the ceiling fan on 10.13.2 instead of Linux. Thanks!

leinelissen · 2017-12-07T08:38:50Z

@Guzmandius npm install git+https://github.com/PolideaInternal/noble.git#macos_highsierra

elovin · 2017-12-08T14:37:05Z

when can we expect this to be merged into noble ?

vikeri · 2018-01-09T11:41:16Z

For anyone with the Descriptor issue, this PR fixed that for me: #727

pchinjr · 2018-01-09T15:45:48Z

Thanks for doing this @Axadiw, it worked great for me with node-rolling-spider and resolved my issue. I'm on a 2016 Macbook Pro with High Sierra 10.13.2 and Node 8.9.4

pchinjr · 2018-01-17T20:15:39Z

Hi everyone, I'm back, after further testing. I am running into an issue with notifications on one of the characteristics in Node-Rolling-Spider. voodootikigod/node-rolling-spider#103 So I'm currently bouncing back and forth between rolling-spider and noble, to understand what is going on with the way High Sierra is interacting with Rolling-Spider. Thanks everyone!

jacobrosenthal · 2018-01-17T22:13:54Z

Superceded by #727

Added support for HighSierra

10be5e5

enami reviewed Sep 29, 2017

View reviewed changes

Fixed wrong XPC id for BLE state change on MacOS HighSierra

cb08187

Axadiw mentioned this pull request Oct 9, 2017

Packets can be received by Linux but not Mac #693

Closed

Changed debug messages to highsierra instead of yosemite

4a18e3e

andrewjaykeller mentioned this pull request Oct 13, 2017

Ganglion not detected on Mac OS OpenBCI/OpenBCI_GUI#260

Closed

This was referenced Oct 27, 2017

Not working on macOS High Sierra currantlabs/ble#58

Open

Premininary support for OS X High Sierra go-ble/ble#2

Merged

andrewjaykeller mentioned this pull request Oct 28, 2017

macOS 10.13 Exception NSInvalidArgumentException pybluez/pybluez#165

Closed

bennesp mentioned this pull request Nov 5, 2017

Not working after macOS High Sierra Upgrade #709

Closed

moogle19 mentioned this pull request Nov 16, 2017

Unhandled events - OSX High Sierra go-ble/ble#3

Closed

leinelissen approved these changes Nov 16, 2017

View reviewed changes

dfrankland suggested changes Nov 19, 2017

View reviewed changes

jacobrosenthal mentioned this pull request Dec 26, 2017

High Sierra support #727

Merged

pchinjr mentioned this pull request Jan 17, 2018

Bluetooth issue on High Sierra preventing takeoff after landing. voodootikigod/node-rolling-spider#103

Open

jacobrosenthal closed this Jan 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for MacOS HighSierra #689

Added support for MacOS HighSierra #689

Axadiw commented Sep 27, 2017

enami Sep 29, 2017

Axadiw Sep 29, 2017 •

edited

Loading

mlcloudsec commented Oct 5, 2017 •

edited

Loading

achingbrain commented Oct 10, 2017

Axadiw commented Oct 10, 2017

andrewjaykeller commented Oct 13, 2017

vikeri commented Oct 16, 2017

andrewjaykeller commented Oct 16, 2017

sid9102 commented Oct 16, 2017

andrewjaykeller commented Oct 17, 2017 •

edited

Loading

andrewjaykeller commented Oct 18, 2017

taktran commented Oct 24, 2017

nisargap commented Nov 1, 2017

bennesp commented Nov 5, 2017 •

edited

Loading

JackCurrie commented Nov 16, 2017

leinelissen commented Nov 16, 2017

alexandrevilain commented Nov 18, 2017

dfrankland left a comment

dfrankland Nov 19, 2017

josschne Nov 21, 2017 •

edited

Loading

jacobrosenthal Dec 24, 2017

jacobrosenthal Dec 24, 2017

gpgabriel commented Nov 24, 2017 •

edited

Loading

gpgabriel commented Nov 27, 2017 •

edited

Loading

hanhdt commented Dec 1, 2017 •

edited

Loading

Guzmandius commented Dec 7, 2017

leinelissen commented Dec 7, 2017

elovin commented Dec 8, 2017

vikeri commented Jan 9, 2018

pchinjr commented Jan 9, 2018

pchinjr commented Jan 17, 2018

jacobrosenthal commented Jan 17, 2018

Added support for MacOS HighSierra #689

Added support for MacOS HighSierra #689

Conversation

Axadiw commented Sep 27, 2017

enami Sep 29, 2017

Choose a reason for hiding this comment

Axadiw Sep 29, 2017 • edited Loading

Choose a reason for hiding this comment

mlcloudsec commented Oct 5, 2017 • edited Loading

achingbrain commented Oct 10, 2017

Axadiw commented Oct 10, 2017

andrewjaykeller commented Oct 13, 2017

vikeri commented Oct 16, 2017

andrewjaykeller commented Oct 16, 2017

sid9102 commented Oct 16, 2017

andrewjaykeller commented Oct 17, 2017 • edited Loading

andrewjaykeller commented Oct 18, 2017

taktran commented Oct 24, 2017

nisargap commented Nov 1, 2017

bennesp commented Nov 5, 2017 • edited Loading

JackCurrie commented Nov 16, 2017

leinelissen commented Nov 16, 2017

alexandrevilain commented Nov 18, 2017

dfrankland left a comment

Choose a reason for hiding this comment

dfrankland Nov 19, 2017

Choose a reason for hiding this comment

josschne Nov 21, 2017 • edited Loading

Choose a reason for hiding this comment

jacobrosenthal Dec 24, 2017

Choose a reason for hiding this comment

jacobrosenthal Dec 24, 2017

Choose a reason for hiding this comment

gpgabriel commented Nov 24, 2017 • edited Loading

gpgabriel commented Nov 27, 2017 • edited Loading

hanhdt commented Dec 1, 2017 • edited Loading

Guzmandius commented Dec 7, 2017

leinelissen commented Dec 7, 2017

elovin commented Dec 8, 2017

vikeri commented Jan 9, 2018

pchinjr commented Jan 9, 2018

pchinjr commented Jan 17, 2018

jacobrosenthal commented Jan 17, 2018

Axadiw Sep 29, 2017 •

edited

Loading

mlcloudsec commented Oct 5, 2017 •

edited

Loading

andrewjaykeller commented Oct 17, 2017 •

edited

Loading

bennesp commented Nov 5, 2017 •

edited

Loading

josschne Nov 21, 2017 •

edited

Loading

gpgabriel commented Nov 24, 2017 •

edited

Loading

gpgabriel commented Nov 27, 2017 •

edited

Loading

hanhdt commented Dec 1, 2017 •

edited

Loading