Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build Mac OS #31

Open
mrkking opened this issue Dec 3, 2019 · 1 comment
Open

Fails to build Mac OS #31

mrkking opened this issue Dec 3, 2019 · 1 comment

Comments

@mrkking
Copy link

mrkking commented Dec 3, 2019

Steps to reproduce:

npm install -g xpc-connection

Os: Catalina 10.15.1
Node: (versions tried) 13.2.0, 131.0, 10.11.0, 9.11.2, 8.16.2

Errors

xpc-connection@0.1.4 install /Users/.nvm/versions/node/v10.11.0/lib/node_modules/xpc-connection

node-gyp rebuild

CXX(target) Release/obj.target/binding/src/XpcConnection.o
../src/XpcConnection.cpp:143:89: error: too few arguments to function call, expected 2, have 1
Local propertyValue = object->GetRealNamedProperty(propertyName->ToString());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/.node-gyp/10.11.0/include/node/v8.h:3558:3: note: 'GetRealNamedProperty' declared here
V8_WARN_UNUSED_RESULT MaybeLocal GetRealNamedProperty(
^
/Users/.node-gyp/10.11.0/include/node/v8config.h:416:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT attribute((warn_unused_result))
^
../src/XpcConnection.cpp:254:12: warning: 'MakeCallback' is deprecated [-Wdeprecated-declarations]
Nan::MakeCallback(Nan::New(this->This), Nan::New("emit").ToLocalChecked(), 2, argv);
^
../node_modules/nan/nan.h:1045:3: note: 'MakeCallback' has been explicitly marked deprecated here
NAN_DEPRECATED inline v8::Localv8::Value MakeCallback(
^
../node_modules/nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'

define NAN_DEPRECATED attribute((deprecated))

                                   ^

../src/XpcConnection.cpp:263:12: warning: 'MakeCallback' is deprecated [-Wdeprecated-declarations]
Nan::MakeCallback(Nan::New(this->This), Nan::New("emit").ToLocalChecked(), 2, argv);
^
../node_modules/nan/nan.h:1045:3: note: 'MakeCallback' has been explicitly marked deprecated here
NAN_DEPRECATED inline v8::Localv8::Value MakeCallback(
^
../node_modules/nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'

define NAN_DEPRECATED attribute((deprecated))

                                   ^

2 warnings and 1 error generated.
make: *** [Release/obj.target/binding/src/XpcConnection.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Users/.nvm/versions/node/v10.11.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:182:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Darwin 19.0.0
gyp ERR! command "/Users/.nvm/versions/node/v10.11.0/bin/node" "/Users/.nvm/versions/node/v10.11.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/nvm/versions/node/v10.11.0/lib/node_modules/xpc-connection
gyp ERR! node -v v10.11.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! xpc-connection@0.1.4 install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the xpc-connection@0.1.4 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/.npm/_logs/2019-12-03T20_28_46_634Z-debug.log

@eugef
Copy link

eugef commented Jan 19, 2020

If you have issues using Noble with latest versions of Node.js or MacOS, you can consider using https://github.com/abandonware/noble instead!
It is a fork which is actively maintained and don't depend on node-xpc-connection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants