Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wave spectrum creation functions from waves.py. Waiting on wavespectra. #154

Open
cmichelenstrofer opened this issue Oct 31, 2022 · 0 comments
Open

Remove wave spectrum creation functions from waves.py. Waiting on wavespectra. #154

cmichelenstrofer opened this issue Oct 31, 2022 · 0 comments
Assignees
@cmichelenstrofer
Labels
upstream Related to a dependency of our package
Milestone
v3.0

Comments

@cmichelenstrofer
Copy link
Member

Once the new version of wavespectra is released (see wavespectra/wavespectra#76)

  1. Contribute anything useful from our code that might be still missing. Could include tests.
  2. Delete those section of the code and tests from our code.
@cmichelenstrofer cmichelenstrofer added the upstream Related to a dependency of our package label Oct 31, 2022
@cmichelenstrofer cmichelenstrofer self-assigned this Oct 10, 2023
@cmichelenstrofer cmichelenstrofer added this to the v3.0 milestone Nov 22, 2023
@jtgrasb jtgrasb mentioned this issue Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmichelenstrofer cmichelenstrofer

Labels
upstream Related to a dependency of our package
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
1 participant
@cmichelenstrofer