Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPI-Enabled Fisher Information Calculations #318

Closed
coreyostrove opened this issue May 19, 2023 · 2 comments
Closed

MPI-Enabled Fisher Information Calculations #318

coreyostrove opened this issue May 19, 2023 · 2 comments
Assignees
@coreyostrove
Labels
enhancement Request for a new feature or a change to an existing feature

Comments

@coreyostrove
Copy link
Contributor

There is now an implementation of the Fisher information that leverages parallelization using MPI. Similarly we have also added flags for operating in a more memory efficient mode in which we avoid storing too many intermediate results. With the exception of a few potential performance tweaks the implementation is essentially complete and looks to produce the correct answers. This lives on the branch feature-globally-germ-aware-fpr (despite in practice having nothing to do with the per-germ global FPR algorithm) and should be merged into develop and included in the next release alongside the new per-germ global FPR algorithm.
@coreyostrove coreyostrove added enhancement Request for a new feature or a change to an existing feature planned-for-next-release labels May 19, 2023
@coreyostrove coreyostrove self-assigned this May 19, 2023
@sserita
Copy link
Contributor

sserita commented Oct 18, 2023

This was merged in via #350 as part of the per-germ global FPR updates.

@sserita sserita added the fixed but not in release yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Oct 18, 2023
@sserita
Copy link
Contributor

sserita commented Nov 29, 2023

Closed with release of 0.9.12.

@sserita sserita closed this as completed Nov 29, 2023
@sserita sserita removed the fixed but not in release yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coreyostrove coreyostrove

Labels
enhancement Request for a new feature or a change to an existing feature
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

feature-globally-germ-aware-fpr sandialabs/pyGSTi
2 participants
@sserita @coreyostrove