Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tensor to something that is not a class name in cp-als (suggestion) #112

Closed
tgkolda opened this issue May 23, 2023 · 0 comments · Fixed by #118
Closed

Rename tensor to something that is not a class name in cp-als (suggestion) #112

tgkolda opened this issue May 23, 2023 · 0 comments · Fixed by #118
Assignees
@DeepBlockDeepak
Labels
dev Making dev life better doing Actively being worked on good first issue Good issue for toe dipping

Comments

@tgkolda
Copy link

tgkolda commented May 23, 2023

It may be helpful to rename tensor to something that is not a class name in cp-als. (And other functions, if they are doing the same thing.)
@ntjohnson1 ntjohnson1 added dev Making dev life better good first issue Good issue for toe dipping labels May 26, 2023
@DeepBlockDeepak DeepBlockDeepak self-assigned this May 30, 2023
@DeepBlockDeepak DeepBlockDeepak added the doing Actively being worked on label May 30, 2023
@DeepBlockDeepak DeepBlockDeepak linked a pull request May 31, 2023 that will close this issue
Changed cp_als() param 'tensor' to 'input_tensor' to avoid ambiguity #118
Merged
@DeepBlockDeepak DeepBlockDeepak mentioned this issue May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeepBlockDeepak DeepBlockDeepak

Labels
dev Making dev life better doing Actively being worked on good first issue Good issue for toe dipping
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed cp_als() param 'tensor' to 'input_tensor' to avoid ambiguity sandialabs/pyttb
3 participants
@tgkolda @ntjohnson1 @DeepBlockDeepak