Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sparse/dense eigenvector warnings #95

Closed
dmdunla opened this issue Apr 20, 2023 · 0 comments · Fixed by #99
Closed

Remove sparse/dense eigenvector warnings #95

dmdunla opened this issue Apr 20, 2023 · 0 comments · Fixed by #99
Assignees
Labels
doing Actively being worked on invalid This doesn't seem right
Milestone

Comments

@dmdunla
Copy link
Collaborator

dmdunla commented Apr 20, 2023

The UserWarnings below appear during testing. We should remove the warnings, as users most likely do not really care about this. The default behavior should be that the right number of eigenvectors are computed, whether sparse or dense routines are used.

tests/test_tucker_als.py::test_tucker_als_tensor_default_init
  C:\Users\dmdunla\dev\github.com\pyttb\pyttb\tensor.py:793: UserWarning: Greater than or equal to tensor.shape[n] - 1 eigenvectors requires cast to dense to solve
    warnings.warn(

pyttb/ktensor.py::pyttb.ktensor.ktensor.nvecs
  C:\Users\dmdunla\dev\github.com\pyttb\pyttb\ktensor.py:1298: UserWarning: Greater than or equal to ktensor.shape[n] - 1 eigenvectors requires cast to dense to solve
    warnings.warn(
@dmdunla dmdunla added the invalid This doesn't seem right label Apr 20, 2023
@dmdunla dmdunla added this to the v2.0 milestone Apr 20, 2023
@dmdunla dmdunla self-assigned this Apr 20, 2023
@ntjohnson1 ntjohnson1 linked a pull request Apr 26, 2023 that will close this issue
@ntjohnson1 ntjohnson1 added the doing Actively being worked on label Apr 26, 2023
@ntjohnson1 ntjohnson1 self-assigned this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doing Actively being worked on invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants