-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to add custom ffmpeg options #19
Comments
Hey, thanks :-) Glad that you like it. First a small note: But now to your problem:
You could try the following, it hopefully works:
The If this does not work, i will add a --ffmpeg-profile parameter for the next release, that inserts the parameter on the right place. Hope it helps. |
Hi, thanks for the reply and its now possible to create aac-he files with m4b-tool.
Also realised, that the generated aac-he files are not compatible to iTunes (importing them is not possible) and found this thread: https://www.computeraudiophile.com/forums/topic/54904-failed-aac_he_v2-experiment-undetected-by-itunes-on-import/?do=findComment&comment=899531 where a solution to that problem is mentioned: I was able to convert to a compatible aac-he (mono v1
Unfortunately I had to do a 265kBit/s encoding with m4b-tool first, to get a concated audio stream with an appropriate chapter.txt file. Still searching the perfect workflow for my projects. Perhaps it is possible to include that aac encoder into m4b-tool. Another thing, but that might be due to a problem with my input audio sources (a playlist from youtube, downloaded with |
Problem 1: Encoding with ProfilesGood find! Thank you. Since I also experimented with AAC_HE_V2 I think it would be nice to integrate another conversion step with fdkaac, since m4b-tool should always produce the best audio quality possible. My suggestion would be the following: I will read through some documentation and forums, e.g.:
Then do a few experiments with fdkaac on different operating systems (since i use m4b-tool on mac, linux and windows):
Then I'll add a new parameter What do you think? Problem 2: Shift between chapters.txt and actual audio contentThere is no logic for this directly integrated, BUT: I got exactly the same problem with a shift, when i used the chapters from music brainz. My solution was the following:
I got pretty good results with this strategy, altough it was not 100%, when the shift was too huge. In your case, it could work, because the overall shift is only 60 seconds. m4b-tool already includes the described logic, but it would need some code improvements, that it could be used for other parts of the software, than the
Second solution would be more flexible, since you could provide every existing mp4-file with chapters, detect silences and move chapter positions according the silences. But this is perhaps much work to do and i can't promise, that this will happen in the near future. |
Solution to Problem 1 sounds ok to me. Might be necessary to make additional tests, since all the final production of the audio is not done via ffmpeg, but fdkaac. By using For Problem 2 I have to investigate more time to understand the issue. In my situation, I have 210 audio files, each is a chapter in the end and the resulting audiobook is 27h in length. |
Ok, here is a build of current master containing both improvements (some free dirty hacks included ;) Would be nice if you find the time to test these. In my case they work nicely on MacOS. Examples: fdkaac usage - produces iTunes compatible high efficiency files
adjust-by-silence - will adjust existing chapters of a file matching nearest silencesThis is a feature I've always wanted to have myself...
|
I close this issue because version 0.3.1 contains all necessary improvements and fixes. If something doesn't work, please reopen the issue. |
Have made some tests and he-aac encoding works fine, but it seems to get confused with temporary file handling. The resulting m4b file only contains the first track, which is repeated by no. of files. Files in test folder:
Here log file output, where the problem can be seen imho:
Listening to the output, this scene came to mind: ;) |
Thanks for testing :-) Should already be fixed in the latest release: Reason was an unclean array structure that has always been pushed instead of being replaced. Let me know if i could do something else... |
Ok. works now. Thx. |
Just made a he-acc_v1 test run of my 210 chapters, 27h audiobook completely with a single invocation of |
This is great news. Thank you very much for your extensive feedback and testing effort. These enhancements will also greatly improve my personal encoding steps a lot. |
Great peace of software, that makes all those mostly unuseable gui apps out there obsolete. Thanks.
I would like to make use of High-Efficiency AAC, since output at 16K bitrate is much better. https://trac.ffmpeg.org/wiki/Encode/AAC#fdk_he
This has already been implemented, https://github.com/sandreas/m4b-tool/blob/master/src/library/M4bTool/Command/MergeCommand.php#L297
How can I add additional options, like
-profile:a aac_he -cutoff 18000
, that get forwarded to FFmpeg?The text was updated successfully, but these errors were encountered: