Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onConflict config option does not apply to implicitly created functions #124

Open
GrantGryczan opened this issue Dec 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@GrantGryczan
Copy link
Contributor

GrantGryczan commented Dec 15, 2021

Practical example:

image

image

image

image

@TheMrZZ TheMrZZ added the bug Something isn't working label Dec 15, 2021
@TheMrZZ
Copy link
Collaborator

TheMrZZ commented Dec 19, 2021

This is actually a non-trivial problem. To fix it correctly, the "implicitely created function" should take the conflict strategy of its parent, or the general one. However, I'd need to rewrite some critical parts of Sandstone (this is planned anyway). But I won't take that risk.

Therefore, I fixed it partially: it will always default to the general strategy if it is "throw", "replace", "ignore" or "warn", but it won't take the conflict strategy of the parent.

@TheMrZZ TheMrZZ reopened this Dec 19, 2021
@MulverineX MulverineX added this to the Future Release milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants