Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use meteor-bundled node #2

Open
rissem opened this issue May 8, 2015 · 4 comments
Open

Use meteor-bundled node #2

rissem opened this issue May 8, 2015 · 4 comments

Comments

@rissem
Copy link

rissem commented May 8, 2015

Currently when using meteor-spk, it complains

Meteor requires Node v0.10.36 or later.

If the Meteor bundled node were used, this shouldn't be an issue.

@kentonv
Copy link
Member

kentonv commented May 8, 2015

I just pushed a new version 0.1.4 to fix this.

If you build meteor-spk from source, then the Makefile actually does pull the Node binary from Meteor. I agree it would be a good idea to make meteor-spk do this at runtime instead, so I'll leave this bug open for that purpose. One complication is that we sort of hope to make meteor-spk work on Mac, but the binaries need to be from Linux in order to run on Sandstorm.

(Another complication is that if we are providing the libraries in the meteor-spk binary package but taking node from Meteor, they could be incompatible even if they're for the same architecture due to version skew, although if this actually happened it would presumably be a problem for Meteor itself running on older systems, so that seems unlikely...)

@mquandalle
Copy link
Contributor

I'm also facing this issue.

I'm using meteor-spk 0.1.4, but want to package a meteor v1.2 app which requires node v0.10.40. I tried to build meteor-spk from source, but it keeps linking the wrong version of nodejs (maybe because meteor v1.2 is still in the release candidates stage, and thus not the default?)

Any idea how I can fix this (even hacky)?

@mquandalle
Copy link
Contributor

OK, I figured out. I replaced the node binary in the deps directory and it works.

@kentonv
Copy link
Member

kentonv commented Aug 29, 2015

@mquandalle That should work for now. If you're blocked on anything I can help with, let me know! Otherwise meteor-spk updates are likely to happen in a week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants