Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Client Type Annotation and Common Parent Class #44

Open
ChihweiLHBird opened this issue Jul 1, 2022 · 0 comments
Open

Test Client Type Annotation and Common Parent Class #44

ChihweiLHBird opened this issue Jul 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ChihweiLHBird
Copy link
Member

ChihweiLHBird commented Jul 1, 2022 •
edited
Loading

The type annotation of Sanic app's test_client currently is Any. Create a better type for it can make test dev experience better. I think adding a parent class, either abstract or non-abstract class, is one of the ways to solve this.
@ChihweiLHBird ChihweiLHBird added the enhancement New feature or request label Jul 1, 2022
@ChihweiLHBird ChihweiLHBird changed the title Test Client Type Annotation Test Client Type Annotation and Common Parent Class Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChihweiLHBird