Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distutils.strtobool deprecation #2388

Closed
sjsadowski opened this issue Jan 23, 2022 · 9 comments · Fixed by #2628
Closed

distutils.strtobool deprecation #2388

sjsadowski opened this issue Jan 23, 2022 · 9 comments · Fixed by #2628
Assignees
Milestone

Comments

@sjsadowski
Copy link
Contributor

Describe the bug
he distutils package is deprecated and slated for removal in Python 3.12. PEP 632

Code snippet
sanic/server/loop.py

Expected behavior
A lack of warnings about deprecation

Environment (please complete the following information):

  • OS: All
  • Version: All supported as of 2022/01/23

Additional context
This is housekeeping to clean up a core python deprecation.

@sjsadowski
Copy link
Contributor Author

Note: Even though this is an exceptionally minor fix, I don't feel like this should be backported to 20.12LTS. 20.12LTS will sunset long before 3.12 is past alpha (and possibly before 3.11.0 final hits, depending on if the timeline in PEP 664 is hit or not) and that makes it likely that 21.12LTS will be the only backport needed, if any.

@ahopkins
Copy link
Member

No backport will be needed because 21.12 does not (an will not) purport to support 3.12. It is 3.7-3.10 and that will not change. We probably should add Python versions here: https://sanic.dev/en/org/policies.html#release-schedule.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions.

@stale stale bot added the stale label Apr 27, 2022
@ChihweiLHBird
Copy link
Member

I think we still need to fix this, right? Any update?

@ahopkins
Copy link
Member

This is still something to do, just not something that we need to release back to the LTS.

@sjsadowski
Copy link
Contributor Author

I'll resurrect this, completely forgot about it.

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@jacebrowning
Copy link

This is still an issue:

from distutils.util import strtobool

@stale stale bot removed the stale label Sep 21, 2022
@ahopkins
Copy link
Member

Anyone want to take a crack at this in the next couple days to get into the LTS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants