Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support react 19, upgrade build tooling #111

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Dec 12, 2024

Upgrading the build tooling and dependencies lead to a number of lint errors that I had to go through and fix, thus the large diff. I had to get rid of the workshop - it was crashing, and has a bunch of peer dependency issues that needs to be resolved if we want to continue using it. For now I just added a stripped down studio with an editor utilizing the input.

@rexxars rexxars requested review from stipsan, snorrees and a team December 12, 2024 00:27
Copy link

socket-security bot commented Dec 12, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/core@7.26.0 environment, filesystem, unsafe Transitive: shell +38 11.1 MB nicolo-ribaudo
npm/@babel/preset-env@7.26.0 environment Transitive: filesystem, shell, unsafe +129 13.9 MB nicolo-ribaudo
npm/@babel/preset-react@7.26.3 Transitive: environment +28 6.55 MB nicolo-ribaudo
npm/@codemirror/autocomplete@6.18.3 None +1 488 kB marijn
npm/@codemirror/commands@6.7.1 None +1 472 kB marijn
npm/@codemirror/lang-html@6.4.9 Transitive: environment +5 687 kB marijn
npm/@codemirror/lang-javascript@6.2.2 Transitive: environment +5 888 kB marijn
npm/@codemirror/lang-markdown@6.3.1 None +2 711 kB marijn
npm/@codemirror/lang-sql@6.8.0 Transitive: environment +2 529 kB marijn
npm/@codemirror/language@6.10.6 Transitive: environment +3 735 kB marijn
npm/@codemirror/legacy-modes@6.4.2 None 0 1.96 MB marijn
npm/@codemirror/search@6.5.8 None +1 139 kB marijn
npm/@codemirror/state@6.5.0 None +1 444 kB marijn
npm/@codemirror/view@6.35.3 None +2 1.19 MB marijn
npm/@commitlint/cli@19.6.0 Transitive: environment, eval, filesystem, shell, unsafe +91 8.37 MB escapedcat
npm/@commitlint/config-conventional@19.6.0 Transitive: filesystem +9 2.46 MB escapedcat
npm/@lezer/highlight@1.2.1 None +1 338 kB marijn
npm/@sanity/icons@2.11.8 None 0 1.27 MB sanity-io
npm/@sanity/pkg-utils@6.12.0 environment Transitive: eval, filesystem, network, shell, unsafe +294 380 MB sanity-io
npm/@sanity/plugin-kit@4.0.18 Transitive: environment, eval, filesystem, network, shell, unsafe +481 596 MB sanity-io
npm/@sanity/semantic-release-preset@4.1.8 Transitive: environment, filesystem, shell +53 2.24 MB sanity-io
npm/@sanity/ui@2.10.9 Transitive: environment +36 14 MB sanity-io
npm/@testing-library/jest-dom@6.6.3 None +15 2.45 MB testing-library-bot
npm/@testing-library/react@14.3.1 environment Transitive: eval +78 11 MB testing-library-bot
npm/@types/jest@29.5.14 Transitive: environment, filesystem, unsafe +38 3.84 MB types
npm/@types/react@18.3.16 None +2 1.69 MB types
npm/@typescript-eslint/eslint-plugin@6.21.0 Transitive: environment, filesystem +41 7.49 MB jameshenry
npm/@typescript-eslint/parser@6.21.0 Transitive: environment, filesystem +33 2.76 MB jameshenry
npm/@uiw/codemirror-themes@4.23.6 None 0 26.5 kB wcjiang
npm/@uiw/react-codemirror@4.23.6 None +7 1.21 MB wcjiang
npm/eslint-config-sanity@7.1.3 None +1 38.3 kB
npm/eslint-plugin-prettier@5.2.1 Transitive: environment +5 255 kB jounqin
npm/eslint-plugin-react-hooks@4.6.2 environment 0 118 kB react-bot
npm/eslint-plugin-react@7.37.2 filesystem Transitive: environment, eval +111 6.33 MB ljharb
npm/eslint@8.57.1 environment, filesystem Transitive: eval, shell, unsafe +97 10.8 MB eslintbot
npm/lint-staged@15.2.11 Transitive: environment, filesystem, shell +39 1.84 MB okonet
npm/prettier-plugin-packagejson@2.5.6 Transitive: environment, filesystem +12 477 kB matzkoh
npm/prettier@3.4.2 None 0 7.83 MB prettier-bot
npm/react-dom@18.3.1 environment +3 4.63 MB react-bot
npm/react-is@18.3.1 environment 0 24 kB react-bot
npm/react@18.3.1 environment +2 339 kB react-bot
npm/rimraf@5.0.10 environment, filesystem Transitive: shell +29 2.02 MB isaacs
npm/sanity@3.67.1 Transitive: environment, eval, filesystem, network, shell, unsafe +719 707 MB ash
npm/semantic-release@24.2.0 environment, network Transitive: eval, filesystem, shell, unsafe +250 35.6 MB semantic-release-bot
npm/styled-components@6.1.13 environment Transitive: filesystem +16 3.83 MB probablyup
npm/ts-jest@29.2.5 environment, filesystem, unsafe Transitive: eval, network, shell +120 12.2 MB kul
npm/typescript@5.7.2 None 0 22.7 MB typescript-bot

🚮 Removed packages: npm/@babel/core@7.23.6, npm/@babel/preset-env@7.23.6, npm/@babel/preset-react@7.23.3, npm/@codemirror/autocomplete@6.11.1, npm/@codemirror/commands@6.3.2, npm/@codemirror/lang-html@6.4.7, npm/@codemirror/lang-javascript@6.2.1, npm/@codemirror/lang-markdown@6.2.3, npm/@codemirror/lang-sql@6.5.4, npm/@codemirror/language@6.9.3, npm/@codemirror/legacy-modes@6.3.3, npm/@codemirror/search@6.5.5, npm/@codemirror/state@6.3.3, npm/@codemirror/view@6.22.3, npm/@commitlint/cli@18.4.3, npm/@commitlint/config-conventional@18.4.3, npm/@lezer/highlight@1.2.0, npm/@sanity/icons@2.8.0, npm/@sanity/pkg-utils@3.3.5, npm/@sanity/plugin-kit@3.1.10, npm/@sanity/semantic-release-preset@4.1.6, npm/@sanity/ui-workshop-plugin-sanity@1.0.0, npm/@sanity/ui-workshop@1.2.11, npm/@sanity/ui@2.0.1, npm/@testing-library/jest-dom@6.1.5, npm/@testing-library/react@14.1.2, npm/@types/jest@29.5.11, npm/@types/react@18.2.45, npm/@typescript-eslint/eslint-plugin@6.14.0, npm/@typescript-eslint/parser@6.14.0, npm/@uiw/codemirror-themes@4.21.21, npm/@uiw/react-codemirror@4.21.21, npm/eslint-config-sanity@7.0.1, npm/eslint-plugin-prettier@5.0.1, npm/eslint-plugin-react-hooks@4.6.0, npm/eslint-plugin-react@7.33.2, npm/eslint@8.55.0, npm/lint-staged@15.2.0, npm/prettier-plugin-packagejson@2.4.7, npm/prettier@3.1.1, npm/react-dom@18.2.0, npm/react-is@18.2.0, npm/react@18.2.0, npm/rimraf@5.0.5, npm/sanity-extra@1.0.0, npm/sanity-testing-library@1.0.0, npm/sanity@3.21.3, npm/semantic-release@22.0.12, npm/styled-components@6.1.1, npm/ts-jest@29.1.1, npm/typescript@5.3.3

View full report↗︎

Copy link
Contributor

@snorrees snorrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! There are some failing tests and something something snyk that needs to be cleaned up before merge.

"sanity-extra": "^1.0.0",
"sanity-testing-library": "^1.0.0",
"semantic-release": "^22.0.0",
"sanity": "^3.67.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It never occurred to me to just do this. So simple, yet so effective.
devDep sanity and a selfcontained sanity.config.ts– so smooth 👍
This is the way plugin-kit should ship.

@rexxars rexxars merged commit d9d2826 into main Dec 14, 2024
10 checks passed
@rexxars rexxars deleted the feat/react-19-update-tooling branch December 14, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants