Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with React v16.8 #1244

Closed
thomax opened this issue Mar 18, 2019 · 7 comments · Fixed by #1435
Closed

Ensure compatibility with React v16.8 #1244

thomax opened this issue Mar 18, 2019 · 7 comments · Fixed by #1435

Comments

@thomax
Copy link
Contributor

thomax commented Mar 18, 2019

Hooks are going to become a popular way doing things in the not-too-distant future. We should ensure that the Content Studio runs smoothly on React v16.8.

Also, do we want to re-write some of your logic to use hooks?

@good-idea
Copy link

I'm writing my plugins using Class components and would love to be able to use hooks. +1 from the plugin side!

@kmelve
Copy link
Member

kmelve commented Jul 2, 2019

I think we should definitively support hooks too. I think we should follow the React teams’ advice of not refactoring, but rather, use hooks when it makes sense in future components.

@skogsmaskin
Copy link
Member

react-hot-loader seemed to be the problem last time we checked up on this.

@nahumzs
Copy link

nahumzs commented Jul 31, 2019

Trying to created a plugin right now with hooks:

TypeError: Cannot read property 'expirationTime' of undefined which seems to be a known issue facebook/react#14767 (comment) can we upgrade at least react-hot-loader to use hooks on the side of the plugins? quite sad not being able to code with hooks.

Screen Shot 2019-07-31 at 1 23 18 PM

@bjoerge
Copy link
Member

bjoerge commented Aug 7, 2019

This has a high priority from our side and hopefully a fix will be available by the end of this week or early next week. Thanks for your patience!

@renatewr
Copy link

I just encountered this error trying to use hooks in an input component. Glad I found this issue though, so I didn't spend more time trying to figure this out.

Seems like react-hot-loader is locked to an older version (

"react-hot-loader": "4.3.8",
), and it could be worth having an eye on gaearon/react-hot-loader#1088

@bjoerge
Copy link
Member

bjoerge commented Aug 13, 2019

A fix has been released in v0.142.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants