Skip to content

Conversation

@binoy14
Copy link
Contributor

@binoy14 binoy14 commented Aug 4, 2025

Description

Removed the "sdk." prefix from request tag prefixes in both token refresh and projection utilities. This change standardizes the request tag format across the codebase.

What to review

  • Check that the requestTagPrefix in refreshStampedToken.ts is now simply 'token-refresh' instead of 'sdk.token-refresh'
  • Verify that the PROJECTION_TAG constant in util.ts is now 'projection' instead of 'sdk.projection'
  • Ensure these changes don't break any existing tag-based filtering or analytics

Testing

Existing tests should cover this change as it's a simple string modification that doesn't affect functionality. The request tags are still unique and identifiable, just with a shorter prefix.

Fun gif

Simplify

@vercel
Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sdk-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 5:52pm
sdk-kitchensink-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 5:52pm

Copy link
Contributor Author

binoy14 commented Aug 4, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@binoy14 binoy14 merged commit 5fbd500 into main Aug 5, 2025
20 checks passed
@binoy14 binoy14 deleted the 08-04-fix_fixes_request_tags branch August 5, 2025 16:38
@squiggler squiggler bot mentioned this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants