feat(projects): add organizationId and includeMembers parameters to useProjects hook #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seProjects hook - Add optional organizationId parameter for filtering projects by organization - Add optional includeMembers parameter (defaults to true, breaking change from false) - Implement parameter-based caching with unique cache keys - BREAKING CHANGE: useProjects() now returns projects with members by default to match the Sanity Client
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ryanbonial
changed the title
ryanbonial
changed the title
binoy14
reviewed
Aug 28, 2025
Contributor
binoy14
left a comment
binoy14
left a comment
There was a problem hiding this comment.
Comment regarding the default but looks good otherwise
| }).observable.pipe( | ||
| switchMap((client) => client.observable.projects.list({includeMembers: false})), | ||
| switchMap((client) => { | ||
| const includeMembers = options?.includeMembers ?? true |
Contributor
There was a problem hiding this comment.
I think we should default to not including members, it can be very slow and we call this on the mount of the SDK, it's also a breaking expectations change which is not really worth changing IMO.
Member
Author
There was a problem hiding this comment.
I switched this back to defaulting to false
| }, | ||
| fetcher: (instance) => (options?: {organizationId?: string; includeMembers?: boolean}) => | ||
| getClientState(instance, { | ||
| apiVersion: API_VERSION, |
Contributor
There was a problem hiding this comment.
Not really part of your PR but since you are here could you also tag the requests so it's more explicit and not sanity.sdk generic
Member
Author
|
Ready for another review |
binoy14
approved these changes
Aug 28, 2025
Contributor
binoy14
left a comment
binoy14
left a comment
There was a problem hiding this comment.
makes sense to me, thanks
Merged
cngonzalez
pushed a commit
that referenced
this pull request
Sep 9, 2025
…seProjects hook (#607) - Add optional organizationId parameter for filtering projects by organization - Add optional includeMembers parameter - Implement parameter-based caching with unique cache keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What to review
The changes to the projects fetcher store in
projects.tswhich now supports filtering by organization and toggling member inclusion. The cache key generation now incorporates these parameters to ensure proper caching behavior.The updated type definitions in
useProjects.tsthat reflect the new parameter options and return types.Testing
Added test coverage for the parameter passing behavior. The test in
projects.test.tsnow verifies that the correct parameters are passed to the list method.Fun gif