chore: fix clippy 1.88 warnings (apache#418)

Author: mbrobbel

src/aws/builder.rs

@@ -1586,7 +1586,7 @@ mod tests {
                 config_key
             );
         } else {
-            panic!("{} not propagated as ClientConfigKey", key);
+            panic!("{key} not propagated as ClientConfigKey");
         }
     }
 
@@ -1605,7 +1605,7 @@ mod tests {
 
         let s3 = builder.build().expect("should build successfully");
         let creds = &s3.client.config.credentials;
-        let debug_str = format!("{:?}", creds);
+        let debug_str = format!("{creds:?}");
         assert!(
             debug_str.contains("EKSPodCredentialProvider"),
             "expected EKS provider but got: {debug_str}"

src/aws/client.rs

@@ -374,7 +374,7 @@ impl Request<'_> {
                     builder.header(CONTENT_TYPE, v.as_ref())
                 }
                 Attribute::Metadata(k_suffix) => builder.header(
-                    &format!("{}{}", USER_DEFINED_METADATA_HEADER_PREFIX, k_suffix),
+                    &format!("{USER_DEFINED_METADATA_HEADER_PREFIX}{k_suffix}"),
                     v.as_ref(),
                 ),
             };

src/aws/credential.rs

@@ -1284,7 +1284,7 @@ mod tests {
             token: Some("temp_token".to_string()),
         };
 
-        let debug_output = format!("{:?}", cred);
+        let debug_output = format!("{cred:?}");
 
         assert!(debug_output.contains("key_id: \"AKIAXXX\""));
         assert!(debug_output.contains("secret_key: \"******\""));

src/aws/precondition.rs

@@ -65,7 +65,7 @@ pub enum S3CopyIfNotExists {
 impl std::fmt::Display for S3CopyIfNotExists {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
-            Self::Header(k, v) => write!(f, "header: {}: {}", k, v),
+            Self::Header(k, v) => write!(f, "header: {k}: {v}"),
             Self::HeaderWithStatus(k, v, code) => {
                 write!(f, "header-with-status: {k}: {v}: {}", code.as_u16())
             }

src/aws/resolve.rs

@@ -49,7 +49,7 @@ impl From<Error> for crate::Error {
 pub async fn resolve_bucket_region(bucket: &str, client_options: &ClientOptions) -> Result<String> {
     use reqwest::StatusCode;
 
-    let endpoint = format!("https://{}.s3.amazonaws.com", bucket);
+    let endpoint = format!("https://{bucket}.s3.amazonaws.com");
 
     let client = client_options.client()?;
 

src/azure/builder.rs

@@ -1245,7 +1245,7 @@ mod tests {
                 config_key
             );
         } else {
-            panic!("{} not propagated as ClientConfigKey", key);
+            panic!("{key} not propagated as ClientConfigKey");
         }
     }
 }

src/azure/client.rs

@@ -243,7 +243,7 @@ impl PutRequest<'_> {
                     builder.header(&MS_CONTENT_TYPE, v.as_ref())
                 }
                 Attribute::Metadata(k_suffix) => builder.header(
-                    &format!("{}{}", USER_DEFINED_METADATA_HEADER_PREFIX, k_suffix),
+                    &format!("{USER_DEFINED_METADATA_HEADER_PREFIX}{k_suffix}"),
                     v.as_ref(),
                 ),
             };
@@ -350,7 +350,7 @@ fn serialize_part_delete_request(
 
     // Encode the subrequest request-line
     extend(dst, b"DELETE ");
-    extend(dst, format!("/{} ", relative_url).as_bytes());
+    extend(dst, format!("/{relative_url} ").as_bytes());
     extend(dst, b"HTTP/1.1");
     extend(dst, b"\r\n");
 
@@ -716,7 +716,7 @@ impl AzureClient {
             .query(&[("restype", "container"), ("comp", "batch")])
             .header(
                 CONTENT_TYPE,
-                HeaderValue::from_str(format!("multipart/mixed; boundary={}", boundary).as_str())
+                HeaderValue::from_str(format!("multipart/mixed; boundary={boundary}").as_str())
                     .unwrap(),
             )
             .header(CONTENT_LENGTH, HeaderValue::from(body_bytes.len()))

src/azure/credential.rs

@@ -261,7 +261,7 @@ impl<'a> AzureAuthorizer<'a> {
             AzureCredential::BearerToken(token) => {
                 request.headers_mut().append(
                     AUTHORIZATION,
-                    HeaderValue::from_str(format!("Bearer {}", token).as_str()).unwrap(),
+                    HeaderValue::from_str(format!("Bearer {token}").as_str()).unwrap(),
                 );
             }
             AzureCredential::SASToken(query_pairs) => {

src/client/builder.rs

@@ -153,7 +153,7 @@ impl HttpRequestBuilder {
 
     #[cfg(feature = "gcp")]
     pub(crate) fn bearer_auth(mut self, token: &str) -> Self {
-        let value = HeaderValue::try_from(format!("Bearer {}", token));
+        let value = HeaderValue::try_from(format!("Bearer {token}"));
         match (value, &mut self.request) {
             (Ok(mut v), Ok(r)) => {
                 v.set_sensitive(true);

src/gcp/builder.rs

@@ -733,7 +733,7 @@ mod tests {
                 config_key
             );
         } else {
-            panic!("{} not propagated as ClientConfigKey", key);
+            panic!("{key} not propagated as ClientConfigKey");
         }
     }
 }