Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTJ] - CS Templates should be checked + Handle Heartbeat for Schneider #3402

Open
LucasBrazi06 opened this issue Oct 10, 2022 · 0 comments
Open
Assignees

Comments

@LucasBrazi06
Copy link
Collaborator

Issue:
Invalid params are filtered and not saved in the DB and the user doesn't know about it!
Schneider OCPP heartbeat param is not following the spec: HeartBeatInterval instead of HeartbeatInterval thus the param is filtered in the backend and saved in the DB without letting know the user!

Todo:
Check if the templates are correct after the Json schema validation in the backend
If different, return an HTTP error code to the user
Handle the error in the UI + display a proper message
Add the HeartBeatInterval in the schema and auth for Schneider.

Done in the corresponding repos
https://github.com/charge-angels/ca-ev-dashboard
https://github.com/charge-angels/ca-ev-server

Nb: I cannot create a PR between the two repos because of too many changes and no time at the moment to create a PR on yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants