Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting loglevel via socket or command line switch #57

Open
christf opened this issue Sep 8, 2019 · 3 comments
Open

Allow setting loglevel via socket or command line switch #57

christf opened this issue Sep 8, 2019 · 3 comments

Comments

@christf
Copy link
Contributor

christf commented Sep 8, 2019

setting loglevel via compile-option is inconvenient as it forces the decision on the person building the firmware whether everyone using the resulting images will be a developer. At the same time it is hampering analysis in images that were not built with verbose debug log in case a ddhcpd issue arises.

Being able to adjust the loglevel would help.

@christf christf changed the title Allow setting loglevel from via socket or command line switch Allow setting loglevel via socket or command line switch Sep 8, 2019
@rubo77
Copy link
Contributor

rubo77 commented Sep 8, 2019

the reason to set this during build is that if you don't need the Log level it should not be built in because it would result in a much larger executable

@christf
Copy link
Contributor Author

christf commented Sep 9, 2019 via email

@sargon
Copy link
Owner

sargon commented Nov 2, 2019

It safes around 20k with the right settings. Updated the README to the changes in the logging implementation. The openwrt package sets it that way, because we are using it in a testbed in that way and we are kind of lazy ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants